Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build geckolib on travis. #12386

Merged
merged 1 commit into from Jul 11, 2016
Merged

Build geckolib on travis. #12386

merged 1 commit into from Jul 11, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 11, 2016 •
edited by larsbergstrom

This adds about two minutes to the twenty-minute build.

This change is Reviewable
@Ms2ger
Build geckolib on travis.
Loading status checks…
04f1b28 
This adds about two minutes to the twenty-minute build.
@nox
Copy link
Member

nox commented Jul 11, 2016

Cool.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

📌 Commit 04f1b28 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

⌛ Testing commit 04f1b28 with merge 3ad7261...
bors-servo added a commit that referenced this pull request Jul 11, 2016
@bors-servo
Auto merge of #12386 - servo:geckolib-travis, r=nox
Loading status checks…
3ad7261 
Build geckolib on travis.

This adds about two minutes to the twenty-minute build.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12386)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member

nox commented Jul 11, 2016

@bors-servo retry #11825
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 11, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 04f1b28 into master Jul 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the geckolib-travis branch Jul 11, 2016
@SimonSapin
Copy link
Member

SimonSapin commented Jul 11, 2016

@larsbergstrom Do you think it would be beneficial to make it a separate entry in the build matrix, so that it builds in parallel? Or is 2 minutes not worth it?
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 11, 2016

The only risk is that it's pretty easy to consume all of our concurrent builds when people are pushing to a bunch of open PRs and then we end up stalled/backlogged. So, I'm not against trying it out, but we might want to make sure we don't end up starving e.g., saltfs PRs or other things sharing the "servo github organization" concurrent build limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @nox @bors-servo @SimonSapin @larsbergstrom @highfive
You can’t perform that action at this time.