Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstyle: Add support to test animations programatically. #12392
Conversation
highfive
commented
Jul 11, 2016
|
Heads up! This PR modifies the following files:
|
|
Reviewed 2 of 2 files at r1, 19 of 19 files at r2. components/servo/Cargo.lock, line 1168 [r2] (raw file):
You probably want to run something like components/style/matching.rs, line 461 [r2] (raw file):
This is an usual place to insert a line break. Is it needed at all? components/style/timer.rs, line 52 [r2] (raw file):
Should this panic in non-test mode? I think an Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 3 unresolved discussions. components/servo/Cargo.lock, line 1168 [r2] (raw file):
|
|
@bors-servo r+ Reviewed 4 of 4 files at r3. Comments from Reviewable |
|
|
|
|
|
|
|
@bors-servo: r=SimonSapin |
|
|
style: Add support to test animations programatically. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12120 <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> r? @SimonSapin for the style changes, @Ms2ger or @jdm for the dom and test changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12392) <!-- Reviewable:end -->
|
|
emilio commentedJul 11, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsr? @SimonSapin for the style changes, @Ms2ger or @jdm for the dom and test changes
This change is