Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include screenshots in css test html log #12403

Closed
wants to merge 1 commit into from
Closed

Include screenshots in css test html log #12403

wants to merge 1 commit into from

Conversation

@shinglyu
Copy link
Member

shinglyu commented Jul 12, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12401 (github issue number if applicable).
  • These changes do not require tests because mozlog has its own tests.

This change is Reviewable
@shinglyu
Include screenshots in css test html log
Loading status checks…
148ecf0
@highfive
Copy link

highfive commented Jul 12, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/requirements.txt
  • @jgraham: tests/wpt/harness/wptrunner/executors/base.py, tests/wpt/harness/requirements.txt
@shinglyu
Copy link
Member Author

shinglyu commented Jul 12, 2016 •
edited

Before:

selection_011

After:

selection_012

There are screenshots (green and white block) left to the logs. User can click the image to zoom in.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 12, 2016

This needs to go upstream.
@Ms2ger Ms2ger assigned Ms2ger and unassigned wafflespeanut Jul 12, 2016
@shinglyu
Copy link
Member Author

shinglyu commented Jul 13, 2016

By upstream do you mean wptrunner or mozlog?
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 13, 2016

The code you're changing is in wptrunner, but if you think it would fit better in mozlog (it might be useful for Gecko's legacy reftests too), feel free to convince the maintainers of that :)
@shinglyu
Copy link
Member Author

shinglyu commented Jul 14, 2016

I'll refactor the patch and move the change to mozlog instead. Modifying wptrunner to fit Gecko's log format sounds wierd.
@shinglyu
Copy link
Member Author

shinglyu commented Jul 15, 2016

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1287019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 17, 2016

☔ The latest upstream changes (presumably #12480) made this pull request unmergeable. Please resolve the merge conflicts.
@chenpighead chenpighead mentioned this pull request Jul 19, 2016
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this pull request Jul 20, 2016
@bors-servo
Auto merge of #12510 - chenpighead:update-mozlog, r=metajack
Loading status checks…
73cfab0 
Upgrade mozlog package from 3.0 to 3.3.

<!-- Please describe your changes on the following line: -->
Update mozlog to 3.3 so we can have correct reftest screenshots displayed with --log-html.
The original mozlog update bugs are listed as follows:
https://bugzilla.mozilla.org/show_bug.cgi?id=1287019
https://bugzilla.mozilla.org/show_bug.cgi?id=1287480

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12401 and #12403 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this is just a PyPI package version bumping

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Update mozlog to 3.3.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12510)
<!-- Reviewable:end -->
@shinglyu
Copy link
Member Author

shinglyu commented Jul 21, 2016

Closed by #12510
@shinglyu shinglyu closed this Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The --log-html file doesn't have the correct Reftest_Screenshots
5 participants
@shinglyu @highfive @Ms2ger @bors-servo @wafflespeanut
You can’t perform that action at this time.