Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary pub modifiers (#50) #12445

Merged
merged 1 commit into from Jul 14, 2016
Merged

Remove some unnecessary pub modifiers (#50) #12445

merged 1 commit into from Jul 14, 2016

Conversation

@zakorgy
Copy link
Contributor

zakorgy commented Jul 14, 2016 •
edited by larsbergstrom

Removed unnecessary pub modifiers from DOM class functions get_instance_id.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests, because there are no WebBluetooth test API implementation yet.

This change is Reviewable
@zakorgy
Remove some unnecessary pub modifiers (#50)
Loading status checks…
aaf21da
@highfive
Copy link

highfive commented Jul 14, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/bluetoothremotegattcharacteristic.rs, components/script/dom/bluetoothremotegattservice.rs, components/script/dom/bluetoothremotegattdescriptor.rs
@highfive
Copy link

highfive commented Jul 14, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jul 14, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2016

📌 Commit aaf21da has been approved by jdm
@highfive highfive assigned jdm and unassigned wafflespeanut Jul 14, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2016

⌛ Testing commit aaf21da with merge 2cab846...
bors-servo added a commit that referenced this pull request Jul 14, 2016
@bors-servo
Auto merge of #12445 - szeged:pub-remove, r=jdm
Loading status checks…
2cab846 
Remove some unnecessary pub modifiers (#50)

<!-- Please describe your changes on the following line: -->

Removed unnecessary pub modifiers from DOM class functions get_instance_id.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests, because there are no WebBluetooth test API implementation yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12445)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit aaf21da into servo:master Jul 14, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@dati91 dati91 deleted the szeged:pub-remove branch Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@zakorgy @highfive @jdm @bors-servo @wafflespeanut
You can’t perform that action at this time.