Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All our Cargo.toml files should contain an MPL-2.0 license field. #12447

Merged
merged 2 commits into from Jul 14, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

All our Cargo.toml files should contain an MPL-2.0 license field.

  • Loading branch information
asajeffrey committed Jul 14, 2016
commit 62e95c5a6192df4ecc8fd17a25200bb2188795d5
@@ -2,6 +2,7 @@
name = "canvas"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "canvas_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "compositing"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "constellation"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "devtools"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "devtools_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -3,6 +3,7 @@
name = "gfx"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "gfx_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "layout"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "layout_thread"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "layout_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "msg"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "net"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "net_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "plugins"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "profile"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "profile_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -3,6 +3,7 @@
name = "range"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "script"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

build = "build.rs"
@@ -2,6 +2,7 @@
name = "script_layout_interface"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "script_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -3,6 +3,7 @@
name = "servo"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
build = "build.rs"
publish = false

@@ -2,6 +2,7 @@
name = "style"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

build = "build.rs"
@@ -2,6 +2,7 @@
name = "style_traits"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "util"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "webdriver_server"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "geckoservo"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

build = "build.rs"

@@ -2,6 +2,7 @@
name = "gecko_bindings"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -3,6 +3,7 @@ name = "string_cache"
description = "A crate to allow using Gecko's nsIAtom as a replacement for string_cache."
version = "0.2.20"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
publish = false

[lib]
@@ -2,6 +2,7 @@
name = "glutin_app"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "glutin_app"
@@ -295,9 +295,13 @@ def find_reverse_dependencies(dependency, version, content):
def check_toml(file_name, lines):
if not file_name.endswith(".toml"):
raise StopIteration
mpl_licensed = False
for idx, line in enumerate(lines):
if line.find("*") != -1:
yield (idx + 1, "found asterisk instead of minimum version number")
mpl_licensed |= ('license = "MPL-2.0"' in line)
if not mpl_licensed:
yield (0, ".toml file should contain MPL-2.0 license.")

This comment has been minimized.

@frewsxcv

frewsxcv Jul 14, 2016

Member

I know it's the case that servo_tidy might be used for other Servo independent crates. Here's an example. For that particular example though, it's fine since that project is MPLv2. It might be problematic for non MPLv2 examples like rust-url. Should one be worried about that scenario?

This comment has been minimized.

@asajeffrey

asajeffrey Jul 14, 2016

Author Member

Oh good point. https://github.com/search?q=org%3Aservo+servo_tidy&ref=searchresults&type=Code&utf8=%E2%9C%93 shows webrender_traits as the only crate currently using servo_tidy. Is it worth future-proofing against non-MPL crates starting to use test-tidy?



def check_rust(file_name, lines):
@@ -3,6 +3,7 @@
name = "build-apk"
version = "0.0.1"
authors = ["Pierre Krieger <pierre.krieger1708@gmail.com>", "The Servo Project Developers"]
license = "MPL-2.0"

[[bin]]
name = "build-apk"
@@ -2,6 +2,7 @@
name = "compiletest_helper"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "compiletest_helper"
@@ -2,6 +2,7 @@
name = "plugin_compiletest"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "plugin_compiletest"
@@ -2,6 +2,7 @@
name = "gfx_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "gfx_tests"
@@ -2,6 +2,7 @@
name = "layout_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "layout_tests"
@@ -2,6 +2,7 @@
name = "net_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "net_tests"
@@ -2,6 +2,7 @@
name = "net_traits_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "net_traits_tests"
@@ -2,6 +2,7 @@
name = "profile_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "profile_tests"
@@ -2,6 +2,7 @@
name = "script_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "script_tests"
@@ -2,6 +2,7 @@
name = "style_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "style_tests"
@@ -2,6 +2,7 @@
name = "util_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"

[lib]
name = "util_tests"
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.