New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All our Cargo.toml files should contain an MPL-2.0 license field. #12447
Merged
+53
−1
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
All our Cargo.toml files should contain an MPL-2.0 license field.
- Loading branch information
commit 62e95c5a6192df4ecc8fd17a25200bb2188795d5
| @@ -295,9 +295,13 @@ def find_reverse_dependencies(dependency, version, content): | ||
| def check_toml(file_name, lines): | ||
| if not file_name.endswith(".toml"): | ||
| raise StopIteration | ||
| mpl_licensed = False | ||
| for idx, line in enumerate(lines): | ||
| if line.find("*") != -1: | ||
| yield (idx + 1, "found asterisk instead of minimum version number") | ||
| mpl_licensed |= ('license = "MPL-2.0"' in line) | ||
| if not mpl_licensed: | ||
| yield (0, ".toml file should contain MPL-2.0 license.") | ||
asajeffrey
Author
Member
|
||
|
|
||
|
|
||
| def check_rust(file_name, lines): | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I know it's the case that
servo_tidymight be used for other Servo independent crates. Here's an example. For that particular example though, it's fine since that project is MPLv2. It might be problematic for non MPLv2 examples like rust-url. Should one be worried about that scenario?