Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups in autoarray helper #12458

Merged
merged 4 commits into from Jul 16, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Replace gecko_autoarray_longhand with configurable vector_longhand

  • Loading branch information
Manishearth committed Jul 15, 2016
commit 34c82d6e7861c8e8d919512abdabb0ab0773fa38
@@ -37,12 +37,17 @@
// and handle the empty case correctly
<%doc>
To be used in cases where we have a grammar like
"<thing> [ , <thing> ]*", but only support a single value
in servo
"<thing> [ , <thing> ]*". `gecko_only` should be set
to True for cases where Servo takes a single value
and Stylo supports vector values.

If the computed value is the same as the specified value,
setting computed_is_specified to True will introduce additional
optimizations
</%doc>
<%def name="gecko_autoarray_longhand(name, **kwargs)">
<%def name="vector_longhand(name, gecko_only=False, **kwargs)">
<%call expr="longhand(name, **kwargs)">
% if product == "gecko":
% if product == "gecko" or not gecko_only:
use cssparser::ToCss;
use std::fmt;

@@ -10,7 +10,7 @@ ${helpers.predefined_type("background-color", "CSSColor",
"::cssparser::Color::RGBA(::cssparser::RGBA { red: 0., green: 0., blue: 0., alpha: 0. }) /* transparent */",
animatable=True)}

<%helpers:gecko_autoarray_longhand name="background-image" animatable="False">
<%helpers:vector_longhand gecko_only="True" name="background-image" animatable="False">
use cssparser::ToCss;
use std::fmt;
use values::specified::Image;
@@ -70,7 +70,7 @@ ${helpers.predefined_type("background-color", "CSSColor",
}
}
}
</%helpers:gecko_autoarray_longhand>
</%helpers:vector_longhand>

<%helpers:longhand name="background-position" animatable="True">
use cssparser::ToCss;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.