Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace any errors caused by content-provided URLs by warnings. #12463

Merged
merged 1 commit into from Jul 15, 2016
Merged

Replace any errors caused by content-provided URLs by warnings. #12463

merged 1 commit into from Jul 15, 2016

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Jul 15, 2016 •
edited by larsbergstrom

#11841 makes errors generate issue reports, so anything that's content-provided should generate warnings, not errors.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because we don't test error generation

This change is Reviewable
@asajeffrey
Replace any errors caused by content-provided URLs by warnings.
Loading status checks…
d1e5baf
@highfive
Copy link

highfive commented Jul 15, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlscriptelement.rs
@highfive
Copy link

highfive commented Jul 15, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 15, 2016

@bors-servo r+ p=1
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2016

📌 Commit d1e5baf has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned nox Jul 15, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2016

⌛ Testing commit d1e5baf with merge 6f3967b...
bors-servo added a commit that referenced this pull request Jul 15, 2016
@bors-servo
Auto merge of #12463 - asajeffrey:url-errors-should-be-warnings, r=Ms…
Loading status checks…
6f3967b 
…2ger

Replace any errors caused by content-provided URLs by warnings.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test error generation

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12463)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit d1e5baf into servo:master Jul 15, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@asajeffrey @highfive @Ms2ger @bors-servo @nox
You can’t perform that action at this time.