Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use fetch infrastructure to load external scripts #12472
Heads up! This PR modifies the following files:
changed the title from
Make text decorations have the same color as the text if no shadows are present
Use fetch infrastructure to load external scripts
Jul 16, 2016
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, 1 of 1 files at r7.
Don't add code that doesn't do anything.
You're not going to add support for modules, so revert this.
Revert this, it makes
If you're going to keep this, you'd better have a slew of tests for it. If not, revert.
Where did this go?
What does that mean? Either way, if you think there's something to be done, file an issue.
Looks wrong. Spec says "client", which comes to mean "request's client's origin". Client is "settings object"; which is "element's node document's Window object", which defines its origin to be "the origin of the Document with which window is currently associated", which may not be
Comments from Reviewable
Review status: 2 of 8 files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.
It doesn't look like so to me, the spec says to create a classic script if the `<script>` element does not have a src attribute, and it's missing here.
Review status: 0 of 8 files reviewed at latest revision, 11 unresolved discussions.
Even when both are mentioned in https://fetch.spec.whatwg.org/#concept-request-nonce-metadata?