Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on util::opts from canvas crate #12490

Merged
merged 1 commit into from Jul 20, 2016
Merged

Remove dependency on util::opts from canvas crate #12490

merged 1 commit into from Jul 20, 2016

Conversation

@djc
Copy link
Contributor

djc commented Jul 18, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it's a small refactoring.

This change is Reviewable
@highfive
Copy link

highfive commented Jul 18, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
@jdm
Copy link
Member

jdm commented Jul 18, 2016

@bors-servo: r+
Nice cleanup!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2016

📌 Commit 41fcca0 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio Jul 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2016

⌛ Testing commit 41fcca0 with merge 188ae95...
bors-servo added a commit that referenced this pull request Jul 18, 2016
@bors-servo
Auto merge of #12490 - djc:canvas-no-opts, r=jdm
Loading status checks…
188ae95 
Remove dependency on util::opts from canvas crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's a small refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12490)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Jul 18, 2016

@bors-servo: r-
Can we update the Cargo.toml and run ./mach cargo-update -p canvas?
@djc
Copy link
Contributor Author

djc commented Jul 18, 2016

@jdm update which Cargo.toml how? Bump the version number in canvas' one?
@jdm
Copy link
Member

jdm commented Jul 18, 2016

Remove the dependency on util.
@djc
Copy link
Contributor Author

djc commented Jul 18, 2016

@jdm it still needs util for util::thread::spawn_named.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@jdm
Copy link
Member

jdm commented Jul 18, 2016

@bors-servo: r+
My mistake.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2016

📌 Commit 41fcca0 has been approved by jdm
@jdm
Copy link
Member

jdm commented Jul 19, 2016

@bors-servo: clean r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 19, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #12506
@bors-servo
Copy link
Contributor

bors-servo commented Jul 19, 2016

📌 Commit 41fcca0 has been approved by jdm
@jdm
Copy link
Member

jdm commented Jul 19, 2016

@bors-servo: clean retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2016

⌛ Testing commit 41fcca0 with merge 7f8a9ba...
bors-servo added a commit that referenced this pull request Jul 20, 2016
@bors-servo
Auto merge of #12490 - djc:canvas-no-opts, r=jdm
Loading status checks…
7f8a9ba 
Remove dependency on util::opts from canvas crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's a small refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12490)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 20, 2016

Testing...
@Ms2ger Ms2ger closed this Jul 20, 2016
@Ms2ger Ms2ger reopened this Jul 20, 2016
@Ms2ger Ms2ger closed this Jul 20, 2016
@Ms2ger Ms2ger reopened this Jul 20, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 20, 2016

@bors-servo clean
@djc
Remove dependency on util::opts from canvas crate
Loading status checks…
29c7c5b
@djc djc force-pushed the djc:canvas-no-opts branch from 41fcca0 to 29c7c5b Jul 20, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 20, 2016

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2016

📌 Commit 29c7c5b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2016

⌛ Testing commit 29c7c5b with merge 55f1c0a...
bors-servo added a commit that referenced this pull request Jul 20, 2016
@bors-servo
Auto merge of #12490 - djc:canvas-no-opts, r=jdm
Loading status checks…
55f1c0a 
Remove dependency on util::opts from canvas crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's a small refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12490)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2016

💔 Test failed - linux-rel
@jdm
Copy link
Member

jdm commented Jul 20, 2016

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2016

⌛ Testing commit 29c7c5b with merge ca9bc23...
bors-servo added a commit that referenced this pull request Jul 20, 2016
@bors-servo
Auto merge of #12490 - djc:canvas-no-opts, r=jdm
Loading status checks…
ca9bc23 
Remove dependency on util::opts from canvas crate

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's a small refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12490)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 20, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 29c7c5b into servo:master Jul 20, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@djc @highfive @jdm @bors-servo @Ms2ger @emilio
You can’t perform that action at this time.