Implement referrer policy delivery via noreferrer link relation #12493

TheKK · 2016-07-18T13:35:39Z

According to https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-delivery, there's <a>, <link> and <area> could apply this delivery method. This PR contains changes for <a> and <link> but not <area>, since HTMLAreaElement is barely implemented.

We should file another issue for it.

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #11862
There are tests for these changes

This change is

highfive · 2016-07-18T13:35:47Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon.

highfive · 2016-07-18T13:35:47Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/htmlanchorelement.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/htmlscriptelement.rs, components/script/dom/document.rs, components/script/dom/window.rs, components/script/dom/htmllinkelement.rs, components/script/dom/location.rs, components/script/document_loader.rs

jdm · 2016-07-18T15:40:00Z

I don't believe the fallback should occur in that method, since it doesn't match https://w3c.github.io/webappsec-referrer-policy/#determine-policy-for-token .

TheKK · 2016-07-18T15:50:43Z

Oops. I misunderstand this with the empty string referrer policy. fixed.

bors-servo · 2016-07-18T17:55:25Z

☔ The latest upstream changes (presumably #11727) made this pull request unmergeable. Please resolve the merge conflicts.

TheKK · 2016-07-19T06:40:30Z

Hmm. Seems like 1a242d8 change the default referrer policy of Document and change part of my test expectations. I understand it's safer to set default as no-referrer for now, but it makes some of my test expectations from pass to failed and vice versa.

That's quite subtle since those passed tests are actually wrong. What do you think about this?

jdm · 2016-07-19T13:36:29Z

I think now that we implement multiple ways of delivering referrer policies (meta, HTTP header, and attributes) we can switch the default to no-referrer-when-downgrade without concern.

KiChjang · 2016-07-21T04:20:00Z

r? @jdm

bors-servo · 2016-07-21T17:25:18Z

☔ The latest upstream changes (presumably #12468) made this pull request unmergeable. Please resolve the merge conflicts.

jdm · 2016-07-28T17:20:11Z

tests/wpt/mozilla/tests/mozilla/referrer-policy/generic/common.js

+
+    if (referrer_policy) {
+      for (var attr in referrer_policy) {
+        // TODO crashed when you assigned value to rel attribute


File an issue about this, please :)

I found this problem does not exist anymore, so it's fine now.

jdm · 2016-07-28T17:46:36Z

I tried to use reviewable, but either it or Firefox choked. I'll leave a comment when I'm done reviewing the diffs on github.

jdm · 2016-07-28T17:48:48Z

tests/wpt/mozilla/tests/mozilla/referrer-policy/generic/common.js

+    var iframe = appendIframeToBody(url_with_params);
+    iframe.addEventListener("load", function listener() {
+      if ((iframe.contentWindow !== null) &&
+          (iframe.contentWindow.location.toString() === url_with_params)) {


Let's add a return here and remove the else.

jdm · 2016-07-28T17:49:25Z

tests/wpt/mozilla/tests/mozilla/referrer-policy/generic/common.js

+        var xhr = new XMLHttpRequest();
+        xhr.open('GET', '/_mozilla/mozilla/referrer-policy/generic/subresource/stash.py?id=' + id, false);
+        xhr.onreadystatechange = function(e) {
+          if (this.readyState == 4 && this.status == 200) {


If we use onload instead, we don't need these checks.

fixed! So did the others in common.js

jdm · 2016-07-28T17:52:19Z

tests/wpt/mozilla/tests/mozilla/referrer-policy/generic/common.js

+      };
+      xhr.send();
+
+      clearTimeout(timeout_func);


No need to clear the timeout after it's fired.

Won't it cause problem if it fired more than once?

I think you're thinking of setInterval?

jdm · 2016-07-28T17:52:31Z

tests/wpt/mozilla/tests/mozilla/referrer-policy/generic/common.js

+      var xhr = new XMLHttpRequest();
+      xhr.open('GET', '/_mozilla/mozilla/referrer-policy/generic/subresource/stash.py?id=' + id, false);
+      xhr.onreadystatechange = function(e) {
+        if (this.readyState == 4 && this.status == 200) {


Let's use onload instead.

TheKK · 2016-09-20T18:01:56Z

Added!

jdm · 2016-09-20T18:35:43Z

@bors-servo: r+

bors-servo · 2016-09-20T18:35:44Z

📌 Commit a7639d9 has been approved by jdm

bors-servo · 2016-09-20T18:35:47Z

⌛ Testing commit a7639d9 with merge 2945449...


        Auto merge of #12493 - TheKK:referrer_policy_dliver_via_rel, r=jdm

Implement referrer policy delivery via noreferrer link relation According to https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-delivery, there's `<a>`, `<link>` and `<area>` could apply this delivery method. This PR contains changes for `<a>` and `<link>` **but** not `<area>`, since HTMLAreaElement is barely implemented. We should file another issue for it. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11862 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12493)

bors-servo · 2016-09-20T20:47:26Z

💔 Test failed - mac-rel-wpt

highfive · 2016-09-20T20:47:29Z

  ▶ TIMEOUT [expected OK] /webgl/conformance-1.0.3/conformance/textures/origin-clean-conformance.html

jdm · 2016-09-20T22:02:41Z

@bors-servo: retry

#13341

bors-servo · 2016-09-20T22:42:12Z

⌛ Testing commit a7639d9 with merge 8a78e75...


        Auto merge of #12493 - TheKK:referrer_policy_dliver_via_rel, r=jdm

Implement referrer policy delivery via noreferrer link relation According to https://w3c.github.io/webappsec-referrer-policy/#referrer-policy-delivery, there's `<a>`, `<link>` and `<area>` could apply this delivery method. This PR contains changes for `<a>` and `<link>` **but** not `<area>`, since HTMLAreaElement is barely implemented. We should file another issue for it. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11862 - [X] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12493)

bors-servo · 2016-09-21T00:19:19Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

jdm · 2016-09-21T02:32:52Z

Woooo! Thanks for sticking with this, @TheKK!


        Auto merge of #13713 - TheKK:fix_a_tag_referrer_policy_test, r=TheKK

Fix referrer policy tests for a-tag This RP tries to fix referrer policy test for <a> which was introduced in #12493 (sorry for my silly mistake). But the fact that Servo lakes of some functionalities make these tests a little tricky to do. The desired solution for tests for <a> is to: 1. create a document which is running test harness 2. append an `<iframe>` to its parent document and give it a name 3. append and `<a>` to its parent document and set its `target` as `<iframe>`'s name 4. each referrer policy attribute (eg. HTTP header, <meta>) would contribute to `<a>` directly 5. we call `click()` on `<a>` and when the test was done, we call `postMessage()` inside `<iframe>` to notify its parent document And target feature for `<a>` and cross origin `postMessage()` is still on its way. My solution is: 1. create a document which is running test harness 2. append an `<iframe>` to its parent document 3. append and `<a>` into `<iframe>` 4. we call `click()` on `<a>` and `<iframe>` navigate to `<a>`'s href Current solution does not work for some cases: - HTTP header, it only apply to test harness html document but `<a>` inside `<iframe>` - cross origin detection, we navigate `<iframe>` rather than its parent document, which make test expectation wrong One workaround in my mind is to load our test harness html document **inside** `<iframe>` under sandbox, so the test won't run again and we get `<meta>` and HTTP header as we expect. But this would break some consistency in `common.js` and make thing more complex. --- Sorry for the long description. But I'd like to hear more thought before I actually make things dirty, and find the most proper solution for this.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13713)


        Auto merge of #13713 - TheKK:fix_a_tag_referrer_policy_test, r=jdm

Fix referrer policy tests for a-tag This RP tries to fix referrer policy test for <a> which was introduced in #12493 (sorry for my silly mistake). But the fact that Servo lakes of some functionalities make these tests a little tricky to do. The desired solution for tests for <a> is to: 1. create a document which is running test harness 2. append an `<iframe>` to its parent document and give it a name 3. append and `<a>` to its parent document and set its `target` as `<iframe>`'s name 4. each referrer policy attribute (eg. HTTP header, <meta>) would contribute to `<a>` directly 5. we call `click()` on `<a>` and when the test was done, we call `postMessage()` inside `<iframe>` to notify its parent document And target feature for `<a>` and cross origin `postMessage()` is still on its way. My solution is: 1. create a document which is running test harness 2. append an `<iframe>` to its parent document 3. append and `<a>` into `<iframe>` 4. we call `click()` on `<a>` and `<iframe>` navigate to `<a>`'s href Current solution does not work for some cases: - HTTP header, it only apply to test harness html document but `<a>` inside `<iframe>` - cross origin detection, we navigate `<iframe>` rather than its parent document, which make test expectation wrong One workaround in my mind is to load our test harness html document **inside** `<iframe>` under sandbox, so the test won't run again and we get `<meta>` and HTTP header as we expect. But this would break some consistency in `common.js` and make thing more complex. --- Sorry for the long description. But I'd like to hear more thought before I actually make things dirty, and find the most proper solution for this.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13713)


        Auto merge of #13713 - TheKK:fix_a_tag_referrer_policy_test, r=jdm

Fix referrer policy tests for a-tag This RP tries to fix referrer policy test for <a> which was introduced in #12493 (sorry for my silly mistake). But the fact that Servo lakes of some functionalities make these tests a little tricky to do. The desired solution for tests for <a> is to: 1. create a document which is running test harness 2. append an `<iframe>` to its parent document and give it a name 3. append and `<a>` to its parent document and set its `target` as `<iframe>`'s name 4. each referrer policy attribute (eg. HTTP header, <meta>) would contribute to `<a>` directly 5. we call `click()` on `<a>` and when the test was done, we call `postMessage()` inside `<iframe>` to notify its parent document And target feature for `<a>` and cross origin `postMessage()` is still on its way. My solution is: 1. create a document which is running test harness 2. append an `<iframe>` to its parent document 3. append and `<a>` into `<iframe>` 4. we call `click()` on `<a>` and `<iframe>` navigate to `<a>`'s href Current solution does not work for some cases: - HTTP header, it only apply to test harness html document but `<a>` inside `<iframe>` - cross origin detection, we navigate `<iframe>` rather than its parent document, which make test expectation wrong One workaround in my mind is to load our test harness html document **inside** `<iframe>` under sandbox, so the test won't run again and we get `<meta>` and HTTP header as we expect. But this would break some consistency in `common.js` and make thing more complex. --- Sorry for the long description. But I'd like to hear more thought before I actually make things dirty, and find the most proper solution for this.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13713)

highfive assigned KiChjang Jul 18, 2016

highfive added the S-awaiting-review label Jul 18, 2016

TheKK force-pushed the TheKK:referrer_policy_dliver_via_rel branch 3 times, most recently from c379af1 to 930cb0f Jul 18, 2016

TheKK force-pushed the TheKK:referrer_policy_dliver_via_rel branch from 930cb0f to 80f9acd Jul 18, 2016

highfive added the S-needs-rebase label Jul 18, 2016

TheKK force-pushed the TheKK:referrer_policy_dliver_via_rel branch from f355721 to 22294db Jul 18, 2016

TheKK force-pushed the TheKK:referrer_policy_dliver_via_rel branch from f835a06 to a4234f8 Jul 20, 2016

highfive assigned jdm and unassigned KiChjang Jul 21, 2016

KiChjang removed the S-needs-rebase label Jul 21, 2016

highfive added the S-needs-rebase label Jul 21, 2016

TheKK force-pushed the TheKK:referrer_policy_dliver_via_rel branch from a4234f8 to 956acf7 Jul 21, 2016

KiChjang removed the S-needs-rebase label Jul 21, 2016

jdm reviewed Jul 28, 2016
View changes

highfive added S-awaiting-merge and removed S-awaiting-review labels Sep 20, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Sep 20, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Sep 20, 2016

bors-servo merged commit a7639d9 into servo:master Sep 21, 2016
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Sep 21, 2016

bors-servo mentioned this pull request Sep 21, 2016

Use fetch infrastructure to load external scripts #12472

Merged

TheKK deleted the TheKK:referrer_policy_dliver_via_rel branch Sep 21, 2016

TheKK restored the TheKK:referrer_policy_dliver_via_rel branch Sep 21, 2016

TheKK deleted the TheKK:referrer_policy_dliver_via_rel branch Sep 22, 2016

Ms2ger mentioned this pull request Sep 23, 2016

Correctly gets and sets rel content attributes in linkelement #13311

Merged

3 of 3 tasks complete

This was referenced Oct 5, 2016

Implement referrer policy delivery via referrer attribute #11861

Open

Fix referrer policy tests for a-tag #13713

Merged

servo / servo

Implement referrer policy delivery via noreferrer link relation #12493

Implement referrer policy delivery via noreferrer link relation #12493

TheKK commented Jul 18, 2016 •

edited by jdm

highfive commented Jul 18, 2016

highfive commented Jul 18, 2016

jdm commented Jul 18, 2016

TheKK commented Jul 18, 2016

bors-servo commented Jul 18, 2016

TheKK commented Jul 19, 2016

jdm commented Jul 19, 2016

KiChjang commented Jul 21, 2016

bors-servo commented Jul 21, 2016

This comment has been minimized.

This comment has been minimized.

jdm commented Jul 28, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TheKK commented Sep 20, 2016

jdm commented Sep 20, 2016

bors-servo commented Sep 20, 2016

bors-servo commented Sep 20, 2016

bors-servo commented Sep 20, 2016

highfive commented Sep 20, 2016

jdm commented Sep 20, 2016

bors-servo commented Sep 20, 2016

bors-servo commented Sep 21, 2016

jdm commented Sep 21, 2016 •

edited

servo / servo

Join GitHub today

Implement referrer policy delivery via noreferrer link relation #12493

Implement referrer policy delivery via noreferrer link relation #12493

Conversation

TheKK commented Jul 18, 2016 • edited by jdm

highfive commented Jul 18, 2016

highfive commented Jul 18, 2016

jdm commented Jul 18, 2016

TheKK commented Jul 18, 2016

bors-servo commented Jul 18, 2016

TheKK commented Jul 19, 2016

jdm commented Jul 19, 2016

KiChjang commented Jul 21, 2016

bors-servo commented Jul 21, 2016

This comment has been minimized.

This comment has been minimized.

jdm commented Jul 28, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TheKK commented Sep 20, 2016

jdm commented Sep 20, 2016

bors-servo commented Sep 20, 2016

bors-servo commented Sep 20, 2016

bors-servo commented Sep 20, 2016

highfive commented Sep 20, 2016

jdm commented Sep 20, 2016

bors-servo commented Sep 20, 2016

bors-servo commented Sep 21, 2016

jdm commented Sep 21, 2016 • edited

TheKK commented Jul 18, 2016 •

edited by jdm

jdm commented Sep 21, 2016 •

edited