Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[wip] layout: Use a magic pseudo-element for text styles. #12496
+99
−112
Conversation
This is an example that partially addresses #8570, hoping that other people will complete it based on an example like this. Actually, we do approximately the same amount of work now, but we could mark this pseudos as "eagerly" cascaded, and do less work in layout, at the expense of (possibly) wasted work.
highfive
commented
Jul 18, 2016
highfive
commented
Jul 18, 2016
|
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Jul 18, 2016
[wip] layout: Use a magic pseudo-element for text styles. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> This is an example that partially addresses #8570, hoping that other people will complete it based on an example like this. Actually, we do approximately the same amount of work now, but we could mark this pseudos as "eagerly" cascaded, and do less work in layout, at the expense of (possibly) wasted work in style. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12496) <!-- Reviewable:end -->
|
|
highfive
commented
Jul 18, 2016
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2016
[wip] layout: Use a magic pseudo-element for text styles. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> This is an example that partially addresses #8570, hoping that other people will complete it based on an example like this. Actually, we do approximately the same amount of work now, but we could mark this pseudos as "eagerly" cascaded, and do less work in layout, at the expense of (possibly) wasted work in style. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12496) <!-- Reviewable:end -->
|
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2016
[wip] layout: Use a magic pseudo-element for text styles. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] There are tests for these changes <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> This is an example that partially addresses #8570, hoping that other people will complete it based on an example like this. Actually, we do approximately the same amount of work now, but we could mark this pseudos as "eagerly" cascaded, and do less work in layout, at the expense of (possibly) wasted work in style. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12496) <!-- Reviewable:end -->
|
|
highfive
commented
Jul 19, 2016
|
|
Good, I was about to ask for this |
|
r? @pcwalton |
|
|
|
This looks good when rebased and when tests are updated. Thanks! |
|
Closing due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedJul 18, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis is an example that partially addresses
#8570, hoping that other people will
complete it based on an example like this.
Actually, we do approximately the same amount of work now, but we could mark
this pseudos as "eagerly" cascaded, and do less work in layout, at the expense
of (possibly) wasted work in style.
This change is