Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove clipboard crate to due disallowed usage of GPL code #12507
Conversation
highfive
commented
Jul 19, 2016
|
Heads up! This PR modifies the following files:
|
|
@bors-servo r+ Reviewed 7 of 7 files at r1. Comments from Reviewable |
|
|
|
@bors-servo p=10 |
bors-servo
added a commit
that referenced
this pull request
Jul 20, 2016
Remove clipboard crate to due disallowed usage of GPL code <!-- Please describe your changes on the following line: --> Fixes #7578, removing usage of rust-clipboard, which contains a disallowed dependency on GPL code. r? @metajack --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a dependency removal <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12507) <!-- Reviewable:end -->
|
|
|
The cef lock file needs changes. |
larsbergstrom
force-pushed the
larsbergstrom:remove_clipboard
branch
from
ad129d4
to
ecabb18
|
re-r? |
|
@bors-servo: r=metajack |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 20, 2016
Remove clipboard crate to due disallowed usage of GPL code <!-- Please describe your changes on the following line: --> Fixes #7578, removing usage of rust-clipboard, which contains a disallowed dependency on GPL code. r? @metajack --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because it's a dependency removal <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12507) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 21, 2016
…trom Added test-tidy for dependent licenses. <!-- Please describe your changes on the following line: --> Add a test-tidy lint for dependency licenses. Note that #12507 should land first. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because we don't test our lints <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12511) <!-- Reviewable:end -->
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJul 19, 2016
•
edited by wafflespeanut
Fixes #7578, removing usage of rust-clipboard, which contains a disallowed dependency on GPL code.
r? @metajack
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is