Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade mozlog package from 3.0 to 3.3. #12510
Conversation
With this upgrade, we are able to run wpt test with "--log-html" to see visual results on screen.
highfive
commented
Jul 19, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
highfive
commented
Jul 19, 2016
|
Heads up! This PR modifies the following files:
|
|
The wptrunner part of this needs to be fixed upstream (i.e. in https://github.com/w3c/wptrunner) |
|
@jgraham PR: w3c/wptrunner#198 |
|
This also landed upstream now so it should be fine. It would be better if the whole of wptrunner was updated ofc (I don't know if there are any other relevant changes), but it's not essential. |
|
@bors-servo r+ |
|
|
Upgrade mozlog package from 3.0 to 3.3. <!-- Please describe your changes on the following line: --> Update mozlog to 3.3 so we can have correct reftest screenshots displayed with --log-html. The original mozlog update bugs are listed as follows: https://bugzilla.mozilla.org/show_bug.cgi?id=1287019 https://bugzilla.mozilla.org/show_bug.cgi?id=1287480 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12401 and #12403 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because this is just a PyPI package version bumping <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Update mozlog to 3.3. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12510) <!-- Reviewable:end -->
|
|
chenpighead commentedJul 19, 2016
•
edited by larsbergstrom
Update mozlog to 3.3 so we can have correct reftest screenshots displayed with --log-html.
The original mozlog update bugs are listed as follows:
https://bugzilla.mozilla.org/show_bug.cgi?id=1287019
https://bugzilla.mozilla.org/show_bug.cgi?id=1287480
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsUpdate mozlog to 3.3.
This change is