Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that it's safe to modify the DOM before doing so. Fixes #1... #1252

Merged
merged 2 commits into from Dec 3, 2013
Merged

Ensure that it's safe to modify the DOM before doing so. Fixes #1... #1252

merged 2 commits into from Dec 3, 2013

Conversation

@jdm
Copy link
Member

jdm commented Nov 14, 2013

...224.
bors-servo pushed a commit that referenced this pull request Nov 14, 2013
bors-servo
auto merge of #1252 : jdm/servo/layoutassert, r=kmcallister
8269eb7 
...224.
bors-servo pushed a commit that referenced this pull request Nov 14, 2013
bors-servo
auto merge of #1252 : jdm/servo/layoutassert, r=kmcallister
e239c58 
...224.
bors-servo pushed a commit that referenced this pull request Nov 14, 2013
bors-servo
auto merge of #1252 : jdm/servo/layoutassert, r=kmcallister
60df5e4 
...224.
bors-servo pushed a commit that referenced this pull request Nov 15, 2013
bors-servo
auto merge of #1252 : jdm/servo/layoutassert, r=kmcallister
9b8b3a2 
...224.
@jdm
Copy link
Member Author

jdm commented Nov 16, 2013

r? @metajack
@jdm jdm mentioned this pull request Nov 30, 2013
Closed
bors-servo pushed a commit that referenced this pull request Dec 2, 2013
bors-servo
auto merge of #1252 : jdm/servo/layoutassert, r=metajack
7273d65 
...224.
jdm added 2 commits Nov 13, 2013
@jdm
Ensure that it's safe to modify the DOM node pointers before doing so. …
f9f9c42 
…Fixes #1224.
@jdm
Add forgotten test for Element.attributes.
Loading status checks…
b502f03
@jdm

This comment has been minimized.

Sign in to view
Copy link
Owner Author

jdm commented on b502f03 Dec 3, 2013

r=metajack
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on b502f03 Dec 3, 2013

saw approval from jdm, metajack
at jdm@b502f03

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 3, 2013

merging jdm/servo/layoutassert = b502f03 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 3, 2013

jdm/servo/layoutassert = b502f03 merged ok, testing candidate = 529c21b

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 3, 2013

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/678
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/633

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Dec 3, 2013

fast-forwarding master to auto = 529c21b
bors-servo pushed a commit that referenced this pull request Dec 3, 2013
bors-servo
auto merge of #1252 : jdm/servo/layoutassert, r=jdm,metajack
529c21b 
...224.
@bors-servo bors-servo closed this Dec 3, 2013
@bors-servo bors-servo merged commit b502f03 into servo:master Dec 3, 2013
1 check passed
1 check passed
default all tests passed
@jdm jdm deleted the jdm:layoutassert branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jdm @bors-servo
You can’t perform that action at this time.