Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a full Windows package #12525

Closed
wants to merge 1 commit into from

Conversation

@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 20, 2016

Few changes here to the package, mainly:

  1. Include servo.exe
  2. Change servo.sh to servo.cmd and format it properly
  3. Include all of the mingw redistributables so that we can launch Servo

There are still some issues (mainly related to font loading), but at least this is 99% of a Windows build :-)

Fixes #12523

r? @edunham

cc @metajack (cribbed from his DLL list in his MSI PR)


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

highfive commented Jul 20, 2016

Heads up! This PR modifies the following files:

@waddlesplash
Copy link

waddlesplash commented Jul 21, 2016

It'd be nice if we got the list of DLLs programmatically, but it looks like there's no easy way to do that (Qt has a tool that does this called "windeployqt", but it looks like that actually reads the PE files itself.) I'll poke around later, I suppose...

@larsbergstrom larsbergstrom mentioned this pull request Jul 22, 2016
11 of 11 tasks complete
@KiChjang KiChjang closed this Jul 25, 2016
@KiChjang KiChjang reopened this Jul 25, 2016
@KiChjang
Copy link
Member

KiChjang commented Jul 25, 2016

$ ./mach test-tidy --no-progress --all

Checking files for tidiness...

./python/servo/package_commands.py:190: E123 closing bracket does not match indentation of opening bracket's line

./python/servo/package_commands.py:199: Line is longer than 120 characters
@larsbergstrom
Copy link
Contributor Author

larsbergstrom commented Jul 25, 2016

Closing in favor of just landing #11967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.