Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate a full Windows package #12525
Closed
Conversation
highfive
commented
Jul 20, 2016
|
Heads up! This PR modifies the following files:
|
waddlesplash
commented
Jul 21, 2016
|
It'd be nice if we got the list of DLLs programmatically, but it looks like there's no easy way to do that (Qt has a tool that does this called "windeployqt", but it looks like that actually reads the PE files itself.) I'll poke around later, I suppose... |
|
|
Closing in favor of just landing #11967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedJul 20, 2016
•
edited
Few changes here to the package, mainly:
There are still some issues (mainly related to font loading), but at least this is 99% of a Windows build :-)
Fixes #12523
r? @edunham
cc @metajack (cribbed from his DLL list in his MSI PR)
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is