New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulate subpixels through stacking contexts #12543

Merged
merged 1 commit into from Jul 27, 2016

Conversation

Projects
None yet
5 participants
@mrobinson
Member

mrobinson commented Jul 21, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

Instead of simply rounding layer origins and discarding subpixel
offsets, accumulate them by transforming them into the space of the
next child stacking context. This is an attempt to eliminate subpixel
differences that are caused by different stacking context boundaries in
reference tests.

Currently these accumulated subpixels are only used for text
positioning, but the plan is that they can be used for all drawing in
the future.


This change is Reviewable

@mrobinson

This comment has been minimized.

Member

mrobinson commented Jul 21, 2016

This change fixes css-transforms-1_dev/html/css-transforms-3d-on-anonymous-block-001.htm on Linux and I'm hoping will eliminate flakiness in the reference tests (#11574).

@mrobinson

This comment has been minimized.

Member

mrobinson commented Jul 21, 2016

@pcwalton

This comment has been minimized.

Contributor

pcwalton commented Jul 25, 2016

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 25, 2016

📌 Commit 8e9045d has been approved by pcwalton

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 26, 2016

⌛️ Testing commit 8e9045d with merge f7ba231...

bors-servo added a commit that referenced this pull request Jul 26, 2016

Auto merge of #12543 - mrobinson:off-by-one-ng, r=pcwalton
Accumulate subpixels through stacking contexts

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Instead of simply rounding layer origins and discarding subpixel
offsets, accumulate them by transforming them into the space of the
next child stacking context. This is an attempt to eliminate subpixel
differences that are caused by different stacking context boundaries in
reference tests.

Currently these accumulated subpixels are only used for text
positioning, but the plan is that they can be used for all drawing in
the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12543)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 26, 2016

💔 Test failed - mac-rel-css

@highfive

This comment has been minimized.

highfive commented Jul 26, 2016

  ▶ PASS [expected FAIL] /css-transforms-1_dev/html/transform-input-019.htm
Accumulate subpixels through stacking contexts
Instead of simply rounding layer origins and discarding subpixel
offsets, accumulate them by transforming them into the space of the
next child stacking context. This is an attempt to eliminate subpixel
differences that are caused by different stacking context boundaries in
reference tests.

Currently these accumulated subpixels are only used for text
positioning, but the plan is that they can be used for all drawing in
the future.

@mrobinson mrobinson force-pushed the mrobinson:off-by-one-ng branch from 8e9045d to 47e69d1 Jul 27, 2016

@mrobinson

This comment has been minimized.

Member

mrobinson commented Jul 27, 2016

I'm marking the test as passing on !Linux.

@mrobinson

This comment has been minimized.

Member

mrobinson commented Jul 27, 2016

@bors-servo r=pcwalton

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 27, 2016

📌 Commit 47e69d1 has been approved by pcwalton

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 27, 2016

⌛️ Testing commit 47e69d1 with merge 4077ae7...

bors-servo added a commit that referenced this pull request Jul 27, 2016

Auto merge of #12543 - mrobinson:off-by-one-ng, r=pcwalton
Accumulate subpixels through stacking contexts

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Instead of simply rounding layer origins and discarding subpixel
offsets, accumulate them by transforming them into the space of the
next child stacking context. This is an attempt to eliminate subpixel
differences that are caused by different stacking context boundaries in
reference tests.

Currently these accumulated subpixels are only used for text
positioning, but the plan is that they can be used for all drawing in
the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12543)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 27, 2016

@bors-servo bors-servo merged commit 47e69d1 into servo:master Jul 27, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@mrobinson mrobinson deleted the mrobinson:off-by-one-ng branch Jul 27, 2016

notriddle added a commit to notriddle/servo that referenced this pull request Jul 28, 2016

notriddle added a commit to notriddle/servo that referenced this pull request Aug 9, 2016

@metajack metajack referenced this pull request Aug 10, 2016

Open

intermittent solutions meta bug #12424

8 of 18 tasks complete

samuknet added a commit to samuknet/servo that referenced this pull request Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment