Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow running WPT in Firefox #12547
Allow running WPT in Firefox #12547
Conversation
highfive
commented
Jul 22, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jgraham (or someone else) soon. |
highfive
commented
Jul 22, 2016
|
Heads up! This PR modifies the following files:
|
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
|
@bors-servo r+ |
|
|
Allow running WPT in Firefox <!-- Please describe your changes on the following line: --> When working with WPT tests, I find it convenient to compare the results of different browsers / engines. By installing a few more Python packages, we can easily test against Firefox from a Servo checkout. As noted in the updated README.md, this change allows you to check WPT tests in Firefox by adding `--product firefox` to the `./mach test-wpt` command. r? @jgraham --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Either: --> - [x] These changes do not require tests because only the set of test harness packages is changed <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12547) <!-- Reviewable:end -->
|
|
|
Hmm, seems like intermittent tests but the harness itself seems okay, let's try again. @bors-servo: retry |
|
Sorry, bors-servo only listens to people that have at least try access. @bors-servo retry |
|
|
|
|
jryans commentedJul 22, 2016
•
edited by larsbergstrom
When working with WPT tests, I find it convenient to compare the results of different browsers / engines. By installing a few more Python packages, we can easily test against Firefox from a Servo checkout.
As noted in the updated README.md, this change allows you to check WPT tests in Firefox by adding
--product firefoxto the./mach test-wptcommand.r? @jgraham
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is