Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running WPT in Firefox #12547

Merged
merged 1 commit into from Jul 25, 2016

Conversation

@jryans
Copy link
Contributor

commented Jul 22, 2016

When working with WPT tests, I find it convenient to compare the results of different browsers / engines. By installing a few more Python packages, we can easily test against Firefox from a Servo checkout.

As noted in the updated README.md, this change allows you to check WPT tests in Firefox by adding --product firefox to the ./mach test-wpt command.

r? @jgraham


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because only the set of test harness packages is changed

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jul 22, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jgraham (or someone else) soon.

@highfive

This comment has been minimized.

Copy link

commented Jul 22, 2016

Heads up! This PR modifies the following files:

@jgraham

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jgraham

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

📌 Commit 3bc2a56 has been approved by jgraham

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

⌛️ Testing commit 3bc2a56 with merge f5d5898...

bors-servo added a commit that referenced this pull request Jul 25, 2016

Auto merge of #12547 - jryans:wpt-firefox, r=jgraham
Allow running WPT in Firefox

<!-- Please describe your changes on the following line: -->

When working with WPT tests, I find it convenient to compare the results of different browsers / engines. By installing a few more Python packages, we can easily test against Firefox from a Servo checkout.

As noted in the updated README.md, this change allows you to check WPT tests in Firefox by adding `--product firefox` to the `./mach test-wpt` command.

r? @jgraham

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because only the set of test harness packages is changed

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12547)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

💔 Test failed - mac-rel-wpt

@jryans

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2016

Hmm, seems like intermittent tests but the harness itself seems okay, let's try again.

@bors-servo: retry

@KiChjang

This comment has been minimized.

Copy link
Member

commented Jul 25, 2016

Sorry, bors-servo only listens to people that have at least try access.

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

⚡️ Previous build results for android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

@bors-servo bors-servo merged commit 3bc2a56 into servo:master Jul 25, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.