Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12564: Fix "./mach test-tidy --self-test". #12565

Merged
merged 1 commit into from Jul 23, 2016
Merged

Issue #12564: Fix "./mach test-tidy --self-test". #12565

merged 1 commit into from Jul 23, 2016

Conversation

@simartin
Copy link
Contributor

simartin commented Jul 23, 2016 •
edited by larsbergstrom

Fix #12564

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12564
  • There are tests for these changes

This change is Reviewable
@simartin
Issue #12564: Fix "./mach test-tidy --self-test".
Loading status checks…
c35cf9a
@highfive
Copy link

highfive commented Jul 23, 2016

Heads up! This PR modifies the following files:
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 23, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2016

📌 Commit c35cf9a has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned Manishearth Jul 23, 2016
@Ms2ger Ms2ger mentioned this pull request Jul 23, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2016

⌛ Testing commit c35cf9a with merge bdcaa4c...
bors-servo added a commit that referenced this pull request Jul 23, 2016
@bors-servo
Auto merge of #12565 - simartin:issue_12564, r=Ms2ger
Loading status checks…
bdcaa4c 
Issue #12564: Fix "./mach test-tidy --self-test".

Fix #12564

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12564
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12565)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2016

💔 Test failed - linux-rel
@simartin
Copy link
Contributor Author

simartin commented Jul 23, 2016

@bors-servo: retry
@KiChjang
Copy link
Member

KiChjang commented Jul 23, 2016 

Ran 6788 tests finished in 810.0 seconds.
  • 6786 ran as expected. 1998 tests skipped.
  • 2 tests had unexpected subtest results

Tests with unexpected results:
  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:
  └ PASS [expected FAIL] Retaining window.name on history traversal

  ▶ Unexpected subtest result in /_mozilla/mozilla/mozbrowser/iframe_visibility.html:
  │ FAIL [expected PASS] Requesting animation frame composites only when frame is visible
  │   → assert_true: expected true got false
  │ 
  │ iframe.onload</<@http://web-platform.test:8000/_mozilla/mozilla/mozbrowser/iframe_visibility.html:58:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1402:20
  └ Test.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1426:20

@simartin I don't think you should just retry, you'll need to fix 1 test failure and update 1 test expectation (besides, bors-servo only listens to reviewers).
@jdm
Copy link
Member

jdm commented Jul 23, 2016

Those cannot be related to the changes in this PR. We should file them as new intermittent failures.
This was referenced Jul 23, 2016
Open
Closed
@simartin
Copy link
Contributor Author

simartin commented Jul 23, 2016

I've just create an issue created for each intermittent failure (I did not find any issue referencing them, hence they should be new ones).
@KiChjang
Copy link
Member

KiChjang commented Jul 23, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2016

⌛ Testing commit c35cf9a with merge 2e3bc57...
bors-servo added a commit that referenced this pull request Jul 23, 2016
@bors-servo
Auto merge of #12565 - simartin:issue_12564, r=Ms2ger
Loading status checks…
2e3bc57 
Issue #12564: Fix "./mach test-tidy --self-test".

Fix #12564

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12564
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12565)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 23, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit c35cf9a into servo:master Jul 23, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@simartin simartin deleted the simartin:issue_12564 branch Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

./mach test-tidy --self-test failing
7 participants
@simartin @highfive @Ms2ger @bors-servo @KiChjang @jdm @Manishearth
You can’t perform that action at this time.