Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor: Downgrade GCC to 5.4.0-1 #12573

Merged
merged 1 commit into from Jul 24, 2016
Merged

Appveyor: Downgrade GCC to 5.4.0-1 #12573

merged 1 commit into from Jul 24, 2016

Conversation

@UK992
Copy link
Contributor

UK992 commented Jul 23, 2016 •
edited by larsbergstrom

Fix building on Appveyor.

This change is Reviewable
@UK992
Copy link
Contributor Author

UK992 commented Jul 23, 2016

r? @larsbergstrom
@highfive highfive assigned larsbergstrom and unassigned cbrewster Jul 23, 2016
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 24, 2016

This looks awesome!

@jdm can you re-enable appveyor? How are you disabling it? It looks enabled on the Servo project page on appveyor...
@jdm
Copy link
Member

jdm commented Jul 24, 2016

I've been enabling/disabling the webhook, specifically.
@jdm
Copy link
Member

jdm commented Jul 24, 2016

@UK992 could you force push to the branch to kick off an appveyor build?
@UK992
Appveyor: Downgrade GCC to 5.4.0-1
Loading status checks…
d19f45e
@UK992 UK992 force-pushed the UK992:appveyor-fix branch from 0e63e33 to d19f45e Jul 24, 2016
@UK992
Copy link
Contributor Author

UK992 commented Jul 24, 2016

done.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 24, 2016

@bors-servo r+

Thanks a TON for doing this!
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2016

📌 Commit d19f45e has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2016

⌛ Testing commit d19f45e with merge 7ca826c...
bors-servo added a commit that referenced this pull request Jul 24, 2016
@bors-servo
Auto merge of #12573 - UK992:appveyor-fix, r=larsbergstrom
Loading status checks…
7ca826c 
Appveyor: Downgrade GCC to 5.4.0-1

Fix building on Appveyor.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12573)
<!-- Reviewable:end -->
@larsbergstrom larsbergstrom mentioned this pull request Jul 24, 2016
Merged
0 of 5 tasks complete
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2016

💔 Test failed - linux-rel
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 24, 2016

Hrm, I don't see an intermittent for this:

Tests with unexpected results:
  ▶ Unexpected subtest result in /html/browsers/history/the-history-interface/002.html:
  │ FAIL [expected PASS] replaceState should not actually load the new URL
  │   → assert_true: expected true got undefined
  │ 
  │ tests10/<@http://web-platform.test:8000/html/browsers/history/the-history-interface/002.html:258:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1402:20
  │ test@http://web-platform.test:8000/resources/testharness.js:500:9
  └ tests10@http://web-platform.test:8000/html/browsers/history/the-history-interface/002.html:257:9
@jdm
Copy link
Member

jdm commented Jul 24, 2016

File it and cc @connorgbrewster.
@larsbergstrom larsbergstrom mentioned this pull request Jul 24, 2016
Open
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jul 24, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit d19f45e into servo:master Jul 24, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Jul 25, 2016
@bors-servo
Auto merge of #12578 - larsbergstrom:windows_deps, r=metajack
Loading status checks…
521f8c0 
Document Windows installation hacks

<!-- Please describe your changes on the following line: -->
This is based on the awesome work by @UK992 in #12573.

Basically, it downgrades GCC on Windows to 5.4 within the mingw environment. This is a stopgap until #11756 is completed and we no longer need mingw.

Fixes #12512

r? @metajack

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12578)
<!-- Reviewable:end -->
@UK992 UK992 deleted the UK992:appveyor-fix branch Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@UK992 @larsbergstrom @jdm @bors-servo @highfive @cbrewster
You can’t perform that action at this time.