Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWebBluetooth writeValue new Step #12603
Merged
Conversation
highfive
commented
Jul 26, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Jul 26, 2016
|
|
zakorgy
changed the title
|
I'd like to have step annotations above each Rust statement. See examples of step annotations in |
|
Sorry for the missing annotations. We will do this definitely in a different PR, because this is not the only function, that misses step annotations. |
|
Filed #12614 for adding in step annotations for the WebBluetooth stuff. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2016
WebBluetooth writeValue new Step <!-- Please describe your changes on the following line: --> There is a new step in the writeValue function of the BluetoothRemoteGATTCharacteristic: https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-writevalue Step 6.1 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because, there is no WebBluetooth test API implementation yet. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12603) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zakorgy commentedJul 26, 2016
•
edited by larsbergstrom
There is a new step in the writeValue function of the BluetoothRemoteGATTCharacteristic:
https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattcharacteristic-writevalue
Step 6.1
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is