New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows msi directory #12606

Merged
merged 1 commit into from Jul 26, 2016

Conversation

Projects
None yet
5 participants
@larsbergstrom
Contributor

larsbergstrom commented Jul 26, 2016

r? @metajack

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Jul 26, 2016

Heads up! This PR modifies the following files:

@metajack

This comment has been minimized.

Contributor

metajack commented Jul 26, 2016

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 26, 2016

📌 Commit c173668 has been approved by metajack

@KiChjang

This comment has been minimized.

Member

KiChjang commented Jul 26, 2016

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 26, 2016

⌛️ Testing commit c173668 with merge f71b584...

bors-servo added a commit that referenced this pull request Jul 26, 2016

Auto merge of #12606 - larsbergstrom:windows_msi_directory, r=metajack
Fix windows msi directory

<!-- Please describe your changes on the following line: -->
r? @metajack
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12606)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 26, 2016

@bors-servo bors-servo merged commit c173668 into servo:master Jul 26, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@larsbergstrom larsbergstrom deleted the larsbergstrom:windows_msi_directory branch Sep 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment