Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPartial fix for #12415: expose interfaces of some HTML Elements #12617
Conversation
highfive
commented
Jul 27, 2016
|
Heads up! This PR modifies the following files:
|
|
Excellent, thank you! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2016
Partial fix for #12415: expose interfaces of some HTML Elements <!-- Please describe your changes on the following line: --> Fix for interfaces: HTMLHeadingElement.webidl HTMLHRElement.webidl HTMLHtmlElement.webidl HTMLHyperlinkElementUtils.webidl HTMLIFrameElement.webidl HTMLImageElement.webidl HTMLInputElement.webidl HTMLLabelElement.webidl HTMLLegendElement.webidl HTMLLIElement.webidl --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12415 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617) <!-- Reviewable:end -->
|
|
highfive
commented
Jul 28, 2016
|
|
Should I remove the test? Do my changes really make it pass? |
|
It's a test that looks at properties of objects in workers, so it seems reasonable, yes. |
mskrzypkows
force-pushed the
mskrzypkows:expose_interfaces
branch
from
0eb907b
to
6d532cf
|
unexpected-self-properties.html removed |
|
Er, you removed the test itself; only the expectation ( |
|
OK, I'll bring it back :-) |
mskrzypkows
force-pushed the
mskrzypkows:expose_interfaces
branch
from
6d532cf
to
9fa6d50
|
Thank you kindly @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2016
Partial fix for #12415: expose interfaces of some HTML Elements <!-- Please describe your changes on the following line: --> Fix for interfaces: HTMLHeadingElement.webidl HTMLHRElement.webidl HTMLHtmlElement.webidl HTMLHyperlinkElementUtils.webidl HTMLIFrameElement.webidl HTMLImageElement.webidl HTMLInputElement.webidl HTMLLabelElement.webidl HTMLLegendElement.webidl HTMLLIElement.webidl --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12415 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617) <!-- Reviewable:end -->
|
|
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jul 28, 2016
Partial fix for #12415: expose interfaces of some HTML Elements <!-- Please describe your changes on the following line: --> Fix for interfaces: HTMLHeadingElement.webidl HTMLHRElement.webidl HTMLHtmlElement.webidl HTMLHyperlinkElementUtils.webidl HTMLIFrameElement.webidl HTMLImageElement.webidl HTMLInputElement.webidl HTMLLabelElement.webidl HTMLLegendElement.webidl HTMLLIElement.webidl --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12415 <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617) <!-- Reviewable:end -->
|
|
scotttrinh
added a commit
to scotttrinh/servo
that referenced
this pull request
Sep 29, 2016
bors-servo
added a commit
that referenced
this pull request
Oct 1, 2016
Partial fix for #12415: expose WebGL interfaces <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes partially fix #12617 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they do not add any features <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13493) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mskrzypkows commentedJul 27, 2016
•
edited
Fix for interfaces:
HTMLHeadingElement.webidl
HTMLHRElement.webidl
HTMLHtmlElement.webidl
HTMLHyperlinkElementUtils.webidl
HTMLIFrameElement.webidl
HTMLImageElement.webidl
HTMLInputElement.webidl
HTMLLabelElement.webidl
HTMLLegendElement.webidl
HTMLLIElement.webidl
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is