Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing namespace in Windows manifest #12627

Merged
merged 1 commit into from Jul 27, 2016

Conversation

@metajack
Copy link
Contributor

commented Jul 27, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because they must be manually tested

The tag must be in the right namespace, or Windows 7
throws an error.


This change is Reviewable

Fix missing namespace in Windows manifest
The <compatibility> tag must be in the right namespace, or Windows 7
throws an error.
@jdm

This comment has been minimized.

Copy link
Member

commented Jul 27, 2016

@bors-servo: r+
Matches the examples I've seen.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2016

📌 Commit d302ab8 has been approved by jdm

@jdm

This comment has been minimized.

Copy link
Member

commented Jul 27, 2016

@Coder206 Coder206 referenced this pull request Jul 27, 2016

Closed

Windows Nightly blockers #12125

11 of 11 tasks complete
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2016

⌛️ Testing commit d302ab8 with merge 901bb7b...

bors-servo added a commit that referenced this pull request Jul 27, 2016

Auto merge of #12627 - metajack:win7-manifest, r=jdm
Fix missing namespace in Windows manifest

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they must be manually tested

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

The <compatibility> tag must be in the right namespace, or Windows 7
throws an error.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12627)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2016

@bors-servo bors-servo merged commit d302ab8 into servo:master Jul 27, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@metajack metajack deleted the metajack:win7-manifest branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.