Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd option to record frames for playback #12630
Conversation
highfive
commented
Jul 28, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
|
I'm not sure to understand what this is supposed to do. Where is |
|
This is for an issue in webrender :) |
|
|
lanamorgan
force-pushed the
lanamorgan:serialization
branch
2 times, most recently
from
4a76b52
to
a76a2f8
|
|
|
Sorry for the wait, LGTM with some naming nits. |
| @@ -811,6 +820,7 @@ pub fn from_cmdline_args(args: &[String]) -> ArgumentParsingResult { | |||
| dump_display_list: debug_options.dump_display_list, | |||
| dump_display_list_json: debug_options.dump_display_list_json, | |||
| dump_layer_tree: debug_options.dump_layer_tree, | |||
| enable_recording: debug_options.enable_recording, | |||
This comment has been minimized.
This comment has been minimized.
shinglyu
Dec 15, 2016
Member
There is a similar feature for dumping layout frame tree called trace_layout, maybe we should follow the convention and call this trace_webrender or record_webrender, or even record_display_list.
| @@ -361,6 +368,7 @@ pub fn print_debug_usage(app: &str) -> ! { | |||
| print_option("dump-display-list", "Print the display list after each layout."); | |||
| print_option("dump-display-list-json", "Print the display list in JSON form."); | |||
| print_option("dump-layer-tree", "Print the layer tree whenever it changes."); | |||
| print_option("record", "Serializes all frame data sent to webrender and writes to record folder."); | |||
This comment has been minimized.
This comment has been minimized.
shinglyu
Dec 15, 2016
Member
Is "frame data" == display list? Just say "Serialize the display list ..." sounds clearer to me.
| @@ -167,6 +167,9 @@ pub struct Opts { | |||
| /// Dumps the layer tree when it changes. | |||
| pub dump_layer_tree: bool, | |||
|
|
|||
| ///Record and write to disk each frame sent to webrender. | |||
This comment has been minimized.
This comment has been minimized.
shinglyu
Dec 15, 2016
Member
Does this one do the similar thing as the one in DebugOptions? Then we should probably use the same comment.
|
Travis build was failing, is the webrender side ready? |
|
This was subsumed by #14249. |
lanamorgan commentedJul 28, 2016
•
edited
Adds a debug option, -Z record, to record webrender's display lists for debugging.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is