New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Headers API tests. #12636

Merged
merged 1 commit into from Jul 28, 2016

Conversation

Projects
None yet
5 participants
@jdm
Member

jdm commented Jul 28, 2016

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

This will be useful for #12634.


This change is Reviewable

@highfive

This comment has been minimized.

highfive commented Jul 28, 2016

Heads up! This PR modifies the following files:

@pcwalton

This comment has been minimized.

Contributor

pcwalton commented Jul 28, 2016

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 28, 2016

📌 Commit 7428a3f has been approved by pcwalton

@highfive highfive assigned pcwalton and unassigned asajeffrey Jul 28, 2016

@jdm jdm referenced this pull request Jul 28, 2016

Merged

Headers API constructor and methods #12634

3 of 5 tasks complete
@jdm

This comment has been minimized.

Member

jdm commented Jul 28, 2016

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 28, 2016

⌛️ Testing commit 7428a3f with merge dfc007e...

bors-servo added a commit that referenced this pull request Jul 28, 2016

Auto merge of #12636 - jdm:headerstests, r=pcwalton
Enable Headers API tests.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

This will be useful for #12634.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12636)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Jul 28, 2016

@bors-servo bors-servo merged commit 7428a3f into servo:master Jul 28, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment