Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3 licence check template #12650

Merged
merged 1 commit into from Jul 29, 2016
Merged

Add python3 licence check template #12650

merged 1 commit into from Jul 29, 2016

Conversation

@shinglyu
Copy link
Member

shinglyu commented Jul 29, 2016

Add a python3 license template. #11107 uses python3 exclusively so we need this.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because covered by test-tidy self test

This change is Reviewable

@highfive
Copy link

highfive commented Jul 29, 2016

Heads up! This PR modifies the following files:

@wafflespeanut
Copy link
Member

wafflespeanut commented Jul 29, 2016

Doesn't hurt to have that too. Maybe we'll have more python3 code in the near future :)
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2016

📌 Commit 7acc982 has been approved by Wafflespeanut

@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2016

Testing commit 7acc982 with merge 9d795c3...

bors-servo added a commit that referenced this pull request Jul 29, 2016
Add python3 licence check template

<!-- Please describe your changes on the following line: -->

Add a python3 license template. #11107 uses python3 exclusively so we need this.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because covered by test-tidy self test

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12650)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2016

@bors-servo bors-servo merged commit 7acc982 into servo:master Jul 29, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.