Print backtraces for panics, even if the constellation has closed.#12657
Merged
bors-servo merged 1 commit intoservo:masterfrom Aug 11, 2016
Merged
Print backtraces for panics, even if the constellation has closed.#12657bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
highfive
added
the
S-awaiting-review
Contributor
|
☔ The latest upstream changes (presumably #12733) made this pull request unmergeable. Please resolve the merge conflicts. |
asajeffrey
force-pushed
the
panic-backtrace-println
branch
from
15cea90 to
341b9de
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
Contributor
|
📌 Commit 341b9de has been approved by |
highfive
added
S-awaiting-merge
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Aug 11, 2016
Print backtraces for panics, even if the constellation has closed. <!-- Please describe your changes on the following line: --> At the moment, threads rely on the constellation to print out the reason for a panic, so panics that happen after the constellation closes are dropped on the floor. cc @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12626 - [X] These changes do not require tests because they are fixing panic behaviour <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12657) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
highfive
removed
the
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Oct 20, 2016
Fix missing `backtrace` build error on Android <!-- Please describe your changes on the following line: --> The missing `backtrace` causes compile errors when building for Android (introduced by #12657). This PR fixes the problem by enabling `backtrace` on Android too. (This is a fix for #13154) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13855) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 4, 2017
…(from mmatyas:fix_android_backtrace); r=larsbergstrom <!-- Please describe your changes on the following line: --> The missing `backtrace` causes compile errors when building for Android (introduced by servo/servo#12657). This PR fixes the problem by enabling `backtrace` on Android too. (This is a fix for servo/servo#13154) Source-Repo: https://github.com/servo/servo Source-Revision: 2c2d340fbcc38e6069a32ef4b19b5dd44f3ca403
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from mmatyas:fix_android_backtrace); r=larsbergstrom <!-- Please describe your changes on the following line: --> The missing `backtrace` causes compile errors when building for Android (introduced by servo/servo#12657). This PR fixes the problem by enabling `backtrace` on Android too. (This is a fix for servo/servo#13154) Source-Repo: https://github.com/servo/servo Source-Revision: 2c2d340fbcc38e6069a32ef4b19b5dd44f3ca403 UltraBlame original commit: 4e408d9347661981ee1d52ae0939e036deffae55
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from mmatyas:fix_android_backtrace); r=larsbergstrom <!-- Please describe your changes on the following line: --> The missing `backtrace` causes compile errors when building for Android (introduced by servo/servo#12657). This PR fixes the problem by enabling `backtrace` on Android too. (This is a fix for servo/servo#13154) Source-Repo: https://github.com/servo/servo Source-Revision: 2c2d340fbcc38e6069a32ef4b19b5dd44f3ca403 UltraBlame original commit: 4e408d9347661981ee1d52ae0939e036deffae55
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…(from mmatyas:fix_android_backtrace); r=larsbergstrom <!-- Please describe your changes on the following line: --> The missing `backtrace` causes compile errors when building for Android (introduced by servo/servo#12657). This PR fixes the problem by enabling `backtrace` on Android too. (This is a fix for servo/servo#13154) Source-Repo: https://github.com/servo/servo Source-Revision: 2c2d340fbcc38e6069a32ef4b19b5dd44f3ca403 UltraBlame original commit: 4e408d9347661981ee1d52ae0939e036deffae55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, threads rely on the constellation to print out the reason for a panic, so panics that happen after the constellation closes are dropped on the floor. cc @jdm
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is