Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch lifecycle events to service worker object and refactor html tests #12682

Merged
merged 1 commit into from Aug 4, 2016
Merged

Dispatch lifecycle events to service worker object and refactor html tests #12682

merged 1 commit into from Aug 4, 2016

Conversation

@creativcoder
Copy link
Contributor

creativcoder commented Aug 1, 2016 •
edited by larsbergstrom

Changes introduced to dispatch controllerchange, activate and fetch simple events to Service Worker interfaces. The html tests under tests/html/service-workers was also updated to demo the changes.
r? @jdm

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • These changes do not require tests because refactor.

This change is Reviewable
@highfive
Copy link

highfive commented Aug 1, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/serviceworkercontainer.rs, components/script/dom/serviceworkerglobalscope.rs
@highfive
Copy link

highfive commented Aug 1, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented Aug 2, 2016

☔ The latest upstream changes (presumably #12557) made this pull request unmergeable. Please resolve the merge conflicts.
@creativcoder
Dispatch events to service worker object and refactor html tests
Loading status checks…
1b29dfb
@creativcoder creativcoder force-pushed the creativcoder:fire-fetch branch from f9826cb to 1b29dfb Aug 2, 2016
@jdm jdm removed the S-needs-rebase label Aug 2, 2016
@creativcoder creativcoder changed the title Dispatch events to service worker object and refactor html tests Dispatch lifecycle events to service worker object and refactor html tests Aug 3, 2016
@jdm
Copy link
Member

jdm commented Aug 3, 2016

@bors-servo: r+

Reviewed 11 of 11 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

📌 Commit 1b29dfb has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

⌛ Testing commit 1b29dfb with merge 3ff2b09...
bors-servo added a commit that referenced this pull request Aug 4, 2016
@bors-servo
Auto merge of #12682 - creativcoder:fire-fetch, r=jdm
Loading status checks…
3ff2b09 
Dispatch lifecycle events to service worker object and refactor html tests

<!-- Please describe your changes on the following line: -->

Changes introduced to dispatch `controllerchange`, `activate` and `fetch` simple events to Service Worker interfaces. The html tests under `tests/html/service-workers` was also updated to demo the changes.
r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because refactor.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12682)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

💔 Test failed - mac-rel-wpt
@creativcoder
Copy link
Contributor Author

creativcoder commented Aug 4, 2016 

Ran 6802 tests finished in 2148.0 seconds.
  • 6801 ran as expected. 1662 tests skipped.
  • 1 tests had unexpected subtest results

Tests with unexpected results:
  ▶ Unexpected subtest result in /webgl/conformance-1.0.3/conformance/textures/default-texture.html:
  │ FAIL [expected PASS] WebGL test #0: at (0, 0) expected: 0,0,0,255 was 0,255,0,255
  │   → assert_true: at (0, 0) expected: 0,0,0,255 was 0,255,0,255 expected true got false
  │ 
  │ reportTestResultsToHarness/<@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:87:9
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1402:20
  │ test@http://web-platform.test:8000/resources/testharness.js:500:9
  │ reportTestResultsToHarness@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:86:7
  │ testFailed@http://web-platform.test:8000/webgl/conformance-1.0.3/resources/js-test-pre.js:152:5
  │ checkCanvasRectColor@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1046:9
  │ checkCanvasRect@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1072:3
  │ checkCanvas@http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/resources/webgl-test-utils.js:1095:3
  └ @http://web-platform.test:8000/webgl/conformance-1.0.3/conformance/textures/default-texture.html:14:1

Reason being #11618
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 4, 2016

@bors-servo retry #11618
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

⌛ Testing commit 1b29dfb with merge 20b9ce6...
bors-servo added a commit that referenced this pull request Aug 4, 2016
@bors-servo
Auto merge of #12682 - creativcoder:fire-fetch, r=jdm
Loading status checks…
20b9ce6 
Dispatch lifecycle events to service worker object and refactor html tests

<!-- Please describe your changes on the following line: -->

Changes introduced to dispatch `controllerchange`, `activate` and `fetch` simple events to Service Worker interfaces. The html tests under `tests/html/service-workers` was also updated to demo the changes.
r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because refactor.
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12682)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 1b29dfb into servo:master Aug 4, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 4, 2016
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@creativcoder @highfive @bors-servo @jdm @wafflespeanut
You can’t perform that action at this time.