brew package

[paulrouget]

Addressed #12600

This is just a WIP PR to see if this approach is right.

The same way night builds are uploaded every day, we'd like to offer a brew binary package as well.

Step 1 is to package a tarball along the dmg. This is done in package_commands.py.
Step 2 is to upload the package. Done is update_brew.sh.
Step 3 is to update the brew Formula. servo-bin.rb is updated in update_brew.sh.
Step 4 is to trigger update_brew.sh along update_nightly.sh. https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/steps.yml

---

This change is

[highfive]

Heads up! This PR modifies the following files:

• @wafflespeanut: python/servo/package_commands.py
• @aneeshusa: etc/ci/update_brew.sh

[paulrouget]

I don't understand why 'servo' in dylib was here in the first place.

[aneeshusa]

I would much rather just include the necessary files directly in the servo repo.

[aneeshusa]

To clarify, considering homebrew uses git repos as package repos, I would include the servo-bin.rb.in file in the servo repo, and push the rendered nightly versions to another repo.

[aneeshusa]

I'd rather not use m4; I think we can get away with sed instead.

[paulrouget]

Comments addressed.

[paulrouget]

I can't really fully test until it's deployed, but that should do it.

Ready for review.

[larsbergstrom]

Will do today, thanks for doing this!

On Aug 8, 2016, at 10:51 PM, Paul Rouget notifications@github.com wrote:

I can't really fully test until it's deployed, but that should do it.

Ready for review.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#12688 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAdCx5dHUvIiokMlRzyQsSwNOPi6_p2Gks5qd_kwgaJpZM4JaLwN
.

[larsbergstrom]

@paulrouget Is the idea that we would get this landed and have the git pushes failing, and then add a token to the environment on the saltfs side of things for the homebrew-servo repository? Right now, we don't have such a GH token in place that we could use, but I can do a follow-up PR to saltfs and push out the token secret to the builders after this lands.

Otherwise, I'm fine with these changes.

[paulrouget]

@larsbergstrom I'm not sure in which order this should be done. I don't really know how tokens work. I guess we need something like github.com/servo/doc.servo.org.

[larsbergstrom]

@bors-servo r+

OK, lets go ahead and get this in there, and either @edunham or I can follow up with the bits to handle a GH token and uploads on the salt side. Expect the publishing rules to fail until that happens.

[bors-servo]

📌 Commit 7981297 has been approved by larsbergstrom

[bors-servo]

⌛ Testing commit 7981297 with merge b4efdd1...

[bors-servo]

💔 Test failed - linux-rel

[highfive]

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8

[larsbergstrom]

@bors-servo retry

• #11561

[bors-servo]

⌛ Testing commit 7981297 with merge a2ce4aa...

[bors-servo]

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev