Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.12.0-nightly (545a3a94f 2016-08-04) #12712

Merged
merged 1 commit into from Aug 5, 2016
Merged

Update Rust to 1.12.0-nightly (545a3a94f 2016-08-04) #12712

merged 1 commit into from Aug 5, 2016

Conversation

@nox
Copy link
Member

nox commented Aug 3, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Aug 3, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/mod.rs, components/style/traversal.rs, components/style/matching.rs
  • @fitzgen: components/profile/lib.rs
@highfive
Copy link

highfive commented Aug 3, 2016

warning Warning warning

  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 3, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

📌 Commit 0eec418 has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned SimonSapin Aug 3, 2016
components/style/values/specified/mod.rs
@@ -7,7 +7,7 @@ use cssparser::{self, Parser, ToCss, Token};
use euclid::size::Size2D;
#[cfg(feature = "gecko")]
use gecko_bindings::ptr::{GeckoArcPrincipal, GeckoArcURI};
use parser::{ParserContext, ParserContextExtraData};

This comment has been minimized.

Sign in to view
@SimonSapin

SimonSapin Aug 3, 2016

Member

I think you’ll want #[cfg(feature = "gecko")] use parser::ParserContextExtraData; here.
@nox nox force-pushed the rustup branch from 0eec418 to ef3dc1d Aug 3, 2016
@nox
Copy link
Member Author

nox commented Aug 3, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

📌 Commit ef3dc1d has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

⌛ Testing commit ef3dc1d with merge 54e1eb3...
bors-servo added a commit that referenced this pull request Aug 3, 2016
@bors-servo
Auto merge of #12712 - servo:rustup, r=Ms2ger
Loading status checks…
54e1eb3 
Update Rust to 1.12.0-nightly (a005b6785 2016-08-02)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12712)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 3, 2016

💔 Test failed - windows-dev
@jdm
Copy link
Member

jdm commented Aug 3, 2016 

note: C:\buildbot\slave\windows-dev\build\target\debug\deps\libsimd-823390c887f97613.rlib(simd-823390c887f97613.0.o): In function `simd::x86::sse2::{{impl}}::max':
C:/msys64/home/Administrator/.cargo\git\checkouts\simd-a428b8cc9c1d1986\master\src\x86/sse2.rs:259: undefined reference to `llvm.x86.sse2.pmaxs.w'
C:\buildbot\slave\windows-dev\build\target\debug\deps\libsimd-823390c887f97613.rlib(simd-823390c887f97613.0.o): In function `simd::x86::sse2::{{impl}}::min':
C:/msys64/home/Administrator/.cargo\git\checkouts\simd-a428b8cc9c1d1986\master\src\x86/sse2.rs:263: undefined reference to `llvm.x86.sse2.pmins.w'
C:\buildbot\slave\windows-dev\build\target\debug\deps\libsimd-823390c887f97613.rlib(simd-823390c887f97613.0.o): In function `simd::x86::sse2::{{impl}}::max':
C:/msys64/home/Administrator/.cargo\git\checkouts\simd-a428b8cc9c1d1986\master\src\x86/sse2.rs:317: undefined reference to `llvm.x86.sse2.pmaxu.b'
C:\buildbot\slave\windows-dev\build\target\debug\deps\libsimd-823390c887f97613.rlib(simd-823390c887f97613.0.o): In function `simd::x86::sse2::{{impl}}::min':
C:/msys64/home/Administrator/.cargo\git\checkouts\simd-a428b8cc9c1d1986\master\src\x86/sse2.rs:321: undefined reference to `llvm.x86.sse2.pminu.b'
collect2.exe: error: ld returned 1 exit status
@nox nox force-pushed the rustup branch from ef3dc1d to 2e83c48 Aug 4, 2016
@nox
Copy link
Member Author

nox commented Aug 4, 2016

@bors-servo r=Ms2ger p=1
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

📌 Commit 2e83c48 has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

💔 Test failed - linux-rel
@KiChjang
Copy link
Member

KiChjang commented Aug 4, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

⌛ Testing commit 2e83c48 with merge dfe04cb...
bors-servo added a commit that referenced this pull request Aug 4, 2016
@bors-servo
Auto merge of #12712 - servo:rustup, r=Ms2ger
Loading status checks…
dfe04cb 
Update Rust to 1.12.0-nightly (a005b6785 2016-08-02)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12712)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Aug 4, 2016

I don't think retrying this PR will make a difference; #12732 doesn't seem to be intermittent.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 4, 2016

💔 Test failed - mac-rel-css
@KiChjang
Copy link
Member

KiChjang commented Aug 4, 2016

Is blocked on rust-lang/rust#35300.
@nox
Update Rust to 1.12.0-nightly (545a3a94f 2016-08-04)
Loading status checks…
f88302e
@nox nox force-pushed the rustup branch from 2e83c48 to f88302e Aug 5, 2016
@nox nox changed the title Update Rust to 1.12.0-nightly (a005b6785 2016-08-02) Update Rust to 1.12.0-nightly (545a3a94f 2016-08-04) Aug 5, 2016
@nox
Copy link
Member Author

nox commented Aug 5, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

📌 Commit f88302e has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

⌛ Testing commit f88302e with merge 414204c...
bors-servo added a commit that referenced this pull request Aug 5, 2016
@bors-servo
Auto merge of #12712 - servo:rustup, r=Ms2ger
Loading status checks…
414204c 
Update Rust to 1.12.0-nightly (545a3a94f 2016-08-04)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12712)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit f88302e into master Aug 5, 2016
2 of 4 checks passed
2 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 5, 2016
Merged
4 of 5 tasks complete
@nox nox deleted the rustup branch Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@nox @highfive @Ms2ger @bors-servo @jdm @KiChjang @SimonSapin
You can’t perform that action at this time.