Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run git commands only with mach build #12752

Merged
merged 1 commit into from Aug 5, 2016
Merged

Run git commands only with mach build #12752

merged 1 commit into from Aug 5, 2016

Conversation

@UK992
Copy link
Contributor

UK992 commented Aug 5, 2016

This should solve problem with slow run on Windows mention in #12730, which is cause by slow git.


This change is Reviewable

@highfive
Copy link

highfive commented Aug 5, 2016

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/command_base.py, python/servo/build_commands.py
@metajack
Copy link
Contributor

metajack commented Aug 5, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

📌 Commit 6548325 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

Testing commit 6548325 with merge 686ca25...

bors-servo added a commit that referenced this pull request Aug 5, 2016
Run git commands only with mach build

This should solve problem with slow run on Windows mention in #12730, which is cause by slow git.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12752)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

💔 Test failed - mac-rel-wpt

@cbrewster
Copy link
Member

cbrewster commented Aug 5, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 5, 2016

@bors-servo bors-servo merged commit 6548325 into servo:master Aug 5, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@UK992 UK992 deleted the UK992:mach branch Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.