Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate README.md with further openssl instructions #12787
Merged
Conversation
Sometimes building with openssl requires major intervention of pointing the include path to the local installation of openssl, when the brew link refuses to link. - [ X] `./mach build -d` does not report any errors - [ X] `./mach test-tidy` does not report any errors - [ X] These changes do not require tests because it’s a documentation change
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 10, 2016
Update README.md with further openssl instructions Sometimes building with openssl requires major intervention of pointing the include path to the local installation of openssl, when the brew link refuses to link. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it’s a documentation change <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12787) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2016
Update README.md with further openssl instructions Sometimes building with openssl requires major intervention of pointing the include path to the local installation of openssl, when the brew link refuses to link. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it’s a documentation change <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12787) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 11, 2016
|
|
@bors-servo retry #11561 |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2016
Update README.md with further openssl instructions Sometimes building with openssl requires major intervention of pointing the include path to the local installation of openssl, when the brew link refuses to link. - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it’s a documentation change <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12787) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
msreckovic commentedAug 9, 2016
•
edited by wafflespeanut
Sometimes building with openssl requires major intervention of pointing the include path to the local installation of openssl, when the brew link refuses to link.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is