Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove expected-crash state of many WebGL tests on Linux. #12793
Conversation
highfive
commented
Aug 10, 2016
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
|
@bors-servo: r+ @anholt: To give more context, they're skipped because we couldn't reliably test WebGL in our automation (I can't recall right now if it was about xvfb or just timeouts). Thanks! |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 10, 2016
Remove expected-crash state of many WebGL tests on Linux. <!-- Please describe your changes on the following line: --> Clear the expected-crash state on some webgl tests on linux, to reduce the diff necessary when enabling webgl testing on Linux again. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because the changes are to test expectations. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> These tests are still all skipped currently (see #9331), but with skipping removed, these didn't crash with Mesa 12.1 on Haswell (Intel). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12793) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 10, 2016
|
|
@bors-servo: retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 10, 2016
Remove expected-crash state of many WebGL tests on Linux. <!-- Please describe your changes on the following line: --> Clear the expected-crash state on some webgl tests on linux, to reduce the diff necessary when enabling webgl testing on Linux again. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because the changes are to test expectations. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> These tests are still all skipped currently (see #9331), but with skipping removed, these didn't crash with Mesa 12.1 on Haswell (Intel). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12793) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
anholt commentedAug 10, 2016
•
edited by larsbergstrom
Clear the expected-crash state on some webgl tests on linux, to reduce the diff necessary when enabling webgl testing on Linux again.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThese tests are still all skipped currently (see #9331), but with
skipping removed, these didn't crash with Mesa 12.1 on Haswell
(Intel).
This change is