Support 'word-spacing' for geckolib #12795

wafflespeanut · 2016-08-10T08:54:35Z

These changes haven't been tested yet!

./mach build -d does not report any errors
./mach test-tidy does not report any errors
There are tests for these changes

This change is

highfive · 2016-08-10T08:54:38Z

Heads up! This PR modifies the following files:

@bholley: components/style/properties/gecko.mako.rs

highfive · 2016-08-10T08:54:38Z

Warning

These commits modify style code, but no tests are modified. Please consider adding a test!

wafflespeanut · 2016-08-10T08:56:00Z

r? @Manishearth

Manishearth · 2016-08-10T09:06:12Z

components/style/properties/gecko.mako.rs

+                Percentage(f) => self.gecko.mWordSpacing.set_value(CoordDataValue::Percent(f)),
+                Calc(l_p) => self.gecko.mWordSpacing.set_value(CoordDataValue::Calc(l_p.into())),
+            },
+            None => self.gecko.mWordSpacing.set_value(CoordDataValue::Auto),


None should be zero I think. Or None. The spec says 0 but we might be able to get away with using None if gecko layout treats it as the same.

Yes, treat this the same as Length(0)

Manishearth · 2016-08-10T09:12:23Z

components/style/properties/gecko.mako.rs

+
+        match v.0 {
+            Some(lop) => match lop {
+                Length(au) => self.gecko.mWordSpacing.set_value(CoordDataValue::Integer(au.0)),


I think this should be CoordDataValue::Coord

Yes, it should be coord.


        Support 'word-spacing' for geckolib

wafflespeanut · 2016-08-10T09:35:16Z

Comments make sense. I've made the changes :)

Manishearth · 2016-08-11T12:17:51Z

@bors-servo r+

This works.

bors-servo · 2016-08-11T12:17:52Z

📌 Commit 69c422f has been approved by Manishearth

bors-servo · 2016-08-11T12:17:55Z

⌛ Testing commit 69c422f with merge c4aae63...


        Auto merge of #12795 - Wafflespeanut:word_spacing, r=Manishearth

Support 'word-spacing' for geckolib **These changes haven't been tested yet!** --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12795)

bors-servo · 2016-08-11T12:18:21Z

💔 Test failed - windows-dev

Manishearth · 2016-08-11T12:18:56Z

@bors-servo retry

github doesn't like bors


        Auto merge of #12795 - Wafflespeanut:word_spacing, r=Manishearth

Support 'word-spacing' for geckolib **These changes haven't been tested yet!** --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12795)

bors-servo · 2016-08-11T12:18:59Z

⌛ Testing commit 69c422f with merge 45abdd6...

bors-servo · 2016-08-11T12:20:37Z

⌛ Testing commit 69c422f with merge 26e3cf2...


        Auto merge of #12795 - Wafflespeanut:word_spacing, r=Manishearth

Support 'word-spacing' for geckolib **These changes haven't been tested yet!** --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12795)

bors-servo · 2016-08-11T13:18:07Z

💔 Test failed - linux-rel

bors-servo · 2016-08-11T15:53:02Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors-servo · 2016-08-11T15:53:02Z

📌 Commit 69c422f has been approved by Manishearth

Manishearth · 2016-08-11T16:15:45Z

@bors-servo retry

#12818

bors-servo · 2016-08-11T16:15:47Z

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-wpt...

bors-servo · 2016-08-11T17:07:56Z

💔 Test failed - mac-rel-wpt

highfive · 2016-08-11T17:07:58Z

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html

Manishearth · 2016-08-11T17:09:57Z

@bors-servo retry

#8769

bors-servo · 2016-08-11T17:10:00Z

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-08-11T17:16:19Z

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...

bors-servo · 2016-08-11T18:08:09Z

💔 Test failed - mac-rel-wpt

highfive · 2016-08-11T18:08:10Z

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html

Manishearth · 2016-08-12T01:57:45Z

@bors-servo retry

#8769


        Auto merge of #12795 - Wafflespeanut:word_spacing, r=Manishearth

Support 'word-spacing' for geckolib **These changes haven't been tested yet!** --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12795)

bors-servo · 2016-08-12T03:02:02Z

⌛ Testing commit 69c422f with merge a229135...

bors-servo · 2016-08-12T04:04:49Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

highfive assigned glennw Aug 10, 2016

highfive added the S-awaiting-review label Aug 10, 2016

highfive assigned Manishearth and unassigned glennw Aug 10, 2016

Manishearth reviewed Aug 10, 2016
View changes

Support 'word-spacing' for geckolib

Loading status checks…

69c422f

wafflespeanut force-pushed the wafflespeanut:word_spacing branch from 9718dcb to 69c422f Aug 10, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Aug 11, 2016

highfive added S-tests-failed and removed S-awaiting-merge labels Aug 11, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 11, 2016

highfive removed the S-awaiting-merge label Aug 11, 2016

highfive added the S-tests-failed label Aug 11, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 11, 2016

highfive removed the S-awaiting-merge label Aug 11, 2016

highfive added the S-tests-failed label Aug 11, 2016

jdm mentioned this pull request Aug 11, 2016

Intermittent timeout in /_mozilla/css/iframe/hide_layers2.html (Constellation panic) #8769

Closed

highfive added the S-tests-failed label Aug 11, 2016

highfive added S-awaiting-merge and removed S-tests-failed labels Aug 12, 2016

bors-servo merged commit 69c422f into servo:master Aug 12, 2016
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Aug 12, 2016

wafflespeanut deleted the wafflespeanut:word_spacing branch Aug 12, 2016

wafflespeanut mentioned this pull request Aug 12, 2016

Support 'letter spacing' property in gecko-lib #12823

Closed

servo / servo

Support 'word-spacing' for geckolib #12795

Support 'word-spacing' for geckolib #12795

wafflespeanut commented Aug 10, 2016 •

edited by larsbergstrom

highfive commented Aug 10, 2016

highfive commented Aug 10, 2016

wafflespeanut commented Aug 10, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

wafflespeanut commented Aug 10, 2016

Manishearth commented Aug 11, 2016 •

edited

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

Manishearth commented Aug 11, 2016 •

edited

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

Manishearth commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

highfive commented Aug 11, 2016

Manishearth commented Aug 11, 2016 •

edited by jdm

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

highfive commented Aug 11, 2016

Manishearth commented Aug 12, 2016

bors-servo commented Aug 12, 2016

bors-servo commented Aug 12, 2016

servo / servo

Join GitHub today

Support 'word-spacing' for geckolib #12795

Support 'word-spacing' for geckolib #12795

Conversation

wafflespeanut commented Aug 10, 2016 • edited by larsbergstrom

highfive commented Aug 10, 2016

highfive commented Aug 10, 2016

wafflespeanut commented Aug 10, 2016

This comment has been minimized.

Manishearth Aug 10, 2016

This comment has been minimized.

Manishearth Aug 10, 2016

This comment has been minimized.

Manishearth Aug 10, 2016

This comment has been minimized.

Manishearth Aug 10, 2016

wafflespeanut commented Aug 10, 2016

Manishearth commented Aug 11, 2016 • edited

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

Manishearth commented Aug 11, 2016 • edited

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

Manishearth commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

highfive commented Aug 11, 2016

Manishearth commented Aug 11, 2016 • edited by jdm

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

bors-servo commented Aug 11, 2016

highfive commented Aug 11, 2016

Manishearth commented Aug 12, 2016

bors-servo commented Aug 12, 2016

bors-servo commented Aug 12, 2016

wafflespeanut commented Aug 10, 2016 •

edited by larsbergstrom

Manishearth commented Aug 11, 2016 •

edited

Manishearth commented Aug 11, 2016 •

edited

Manishearth commented Aug 11, 2016 •

edited by jdm