Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serde to 0.8 (fixes #12659) #12828

Merged
merged 1 commit into from Aug 12, 2016
Merged

Update serde to 0.8 (fixes #12659) #12828

merged 1 commit into from Aug 12, 2016

Conversation

@nox
Copy link
Member

nox commented Aug 12, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Aug 12, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @asajeffrey: components/constellation/Cargo.toml, components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/lib.rs, components/webdriver_server/Cargo.toml
  • @fitzgen: components/profile/Cargo.toml, components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/profile_traits/Cargo.toml, components/profile_traits/Cargo.toml, components/devtools/Cargo.toml, components/devtools/actors/console.rs, components/devtools/actor.rs, components/devtools/protocol.rs, components/devtools/actors/inspector.rs, components/devtools/actors/tab.rs, components/devtools/actors/timeline.rs
  • @KiChjang: components/net/lib.rs, components/script/webdriver_handlers.rs, components/net_traits/response.rs, components/net_traits/response.rs, components/script/dom/servohtmlparser.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/script/lib.rs, components/net/http_loader.rs, components/script/dom/xmlhttprequest.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/htmlmediaelement.rs, components/net/about_loader.rs, components/script/Cargo.toml, components/script/dom/htmllinkelement.rs, components/net/blob_loader.rs, components/script_traits/webdriver_msg.rs, components/script_traits/webdriver_msg.rs, components/script/script_thread.rs, components/net/resource_thread.rs, components/net/Cargo.toml, components/net/fetch/methods.rs, components/script/dom/htmlscriptelement.rs, components/script_layout_interface/Cargo.toml, components/net_traits/Cargo.toml, components/net_traits/Cargo.toml, components/script_traits/Cargo.toml, components/script_traits/Cargo.toml, components/net_traits/request.rs, components/net_traits/request.rs
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 12, 2016

@bors-servo r+ p=1
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

📌 Commit 72d0bbf has been approved by Ms2ger
@highfive highfive assigned Ms2ger and unassigned pcwalton Aug 12, 2016
bors-servo added a commit that referenced this pull request Aug 12, 2016
@bors-servo
Auto merge of #12828 - nox:serde, r=Ms2ger
Loading status checks…
a7611d4 
Update serde to 0.8 (fixes #12659)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12828)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

⌛ Testing commit 72d0bbf with merge cce7fdf...
bors-servo added a commit that referenced this pull request Aug 12, 2016
@bors-servo
Auto merge of #12828 - nox:serde, r=Ms2ger
Loading status checks…
cce7fdf 
Update serde to 0.8 (fixes #12659)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12828)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

💔 Test failed - linux-dev
@nox
Update serde to 0.8 (fixes #12659)
Loading status checks…
7ad51dc
@nox nox force-pushed the nox:serde branch from 72d0bbf to 7ad51dc Aug 12, 2016
@nox
Copy link
Member Author

nox commented Aug 12, 2016

@bors-servo r=Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

📌 Commit 7ad51dc has been approved by Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

⌛ Testing commit 7ad51dc with merge 9abe9e4...
bors-servo added a commit that referenced this pull request Aug 12, 2016
@bors-servo
Auto merge of #12828 - nox:serde, r=Ms2ger
Loading status checks…
9abe9e4 
Update serde to 0.8 (fixes #12659)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12828)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

💔 Test failed - linux-rel
@nox
Copy link
Member Author

nox commented Aug 12, 2016

@bors-servo retry #8769
@nox
Copy link
Member Author

nox commented Aug 12, 2016

@bors-servo force
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 12, 2016 

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:
  └ PASS [expected FAIL] Retaining window.name on history traversal
@nox
Copy link
Member Author

nox commented Aug 12, 2016

@bors-servo retry #12568
@glennw
Copy link
Member

glennw commented Aug 12, 2016

@nox @Ms2ger This updates the hash for webrender but doesn't copy across the updated shaders, which will break things. Do you want to cancel this on bors and add the shaders to this PR or fix it up after this lands?
@glennw
Copy link
Member

glennw commented Aug 12, 2016

@bors-servo r-
@glennw
Copy link
Member

glennw commented Aug 12, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

📌 Commit 7ad51dc has been approved by glennw
@highfive highfive assigned glennw and unassigned Ms2ger Aug 12, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev are reusable. Rebuilding only linux-rel...
@glennw glennw mentioned this pull request Aug 12, 2016
Merged
0 of 5 tasks complete
@glennw
Copy link
Member

glennw commented Aug 12, 2016

@nox @larsbergstrom #12832
@bors-servo
Copy link
Contributor

bors-servo commented Aug 12, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 7ad51dc into servo:master Aug 12, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Aug 12, 2016
Merged
Merged
@nox nox deleted the nox:serde branch Aug 12, 2016
@Ms2ger Ms2ger mentioned this pull request Feb 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @Ms2ger @bors-servo @glennw @pcwalton
You can’t perform that action at this time.