Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix hit testing to take into account nested stacking contexts #12777 #12841
Conversation
|
@jdm: I was so dumb that I didn't pass the transformed point into the children sc. I'm scared no test caught this. |
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Aug 13, 2016
Fix hit testing to take into account nested stacking contexts #12777 <!-- Please describe your changes on the following line: --> Fixes #12833. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12833 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12841) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 13, 2016
|
|
That's a know intermittent, but just to make sure: @bors-servo: retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 14, 2016
Fix hit testing to take into account nested stacking contexts #12777 <!-- Please describe your changes on the following line: --> Fixes #12833. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12833 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12841) <!-- Reviewable:end -->
|
|
|
@bors-servo: r+ |
|
|
|
Looks like this was never merged, and requires a rebase now. |
|
@bors-servo: r=pcwalton |
|
|
|
@bors-servo: p=1
|
bors-servo
added a commit
that referenced
this pull request
Aug 25, 2016
Fix hit testing to take into account nested stacking contexts #12777 <!-- Please describe your changes on the following line: --> Fixes #12833. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12833 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12841) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedAug 13, 2016
•
edited by larsbergstrom
Fixes #12833.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is