Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplayout: Make the stacking context take into account the children transform when calculating overflow areas. #12843
Conversation
|
r? @pcwalton Doesn't deal with every possible transform, so I'll add that before landing this, but I'd like to verify the approach looks good to you. Also... |
layout: Make the stacking context take into account the children transform when calculating overflow areas. <!-- Please describe your changes on the following line: --> This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partially fix #12842 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12843) <!-- Reviewable:end -->
emilio
force-pushed the
emilio:transforms
branch
3 times, most recently
from
bf0b4bc
to
3458ad8
|
@bors-servo: try |
layout: Make the stacking context take into account the children transform when calculating overflow areas. <!-- Please describe your changes on the following line: --> This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partially fix #12842 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12843) <!-- Reviewable:end -->
|
|
|
I forgot to update the manifest, the rest of tests seem to be passing, but I'll double-check. @bors-servo: try |
layout: Make the stacking context take into account the children transform when calculating overflow areas. <!-- Please describe your changes on the following line: --> This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partially fix #12842 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12843) <!-- Reviewable:end -->
|
|
|
@bors-servo: try |
layout: Make the stacking context take into account the children transform when calculating overflow areas. <!-- Please describe your changes on the following line: --> This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partially fix #12842 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12843) <!-- Reviewable:end -->
|
|
|
Reviewed 4 of 5 files at r1, 5 of 5 files at r2. components/gfx/display_list/mod.rs, line 703 [r2] (raw file):
This doesn't look like it will work with perspective transforms? I think it's fine to merge without that, since it seems like a net improvement, but perhaps add a TODO comment. In particular, browser.html uses a perspective transform with a translateZ to zoom the content in and out. Does this handle that case? tests/wpt/mozilla/meta/MANIFEST.json, line 3963 [r2] (raw file):
This seems like an extra entry? tests/wpt/mozilla/meta/MANIFEST.json, line 13207 [r2] (raw file):
Same here Comments from Reviewable |
|
Reviewed 1 of 5 files at r1. Comments from Reviewable |
|
Review status: 4 of 10 files reviewed at latest revision, 3 unresolved discussions. components/gfx/display_list/mod.rs, line 703 [r2] (raw file):
|
|
@emilio r=me with those fixes |
|
@bors-servo: r=glennw (they were already fixed). |
|
|
layout: Make the stacking context take into account the children transform when calculating overflow areas. <!-- Please describe your changes on the following line: --> This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partially fix #12842 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12843) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 17, 2016
|
|
@bors-servo: retry #9087 |
layout: Make the stacking context take into account the children transform when calculating overflow areas. <!-- Please describe your changes on the following line: --> This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes partially fix #12842 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12843) <!-- Reviewable:end -->
|
|
emilio commentedAug 13, 2016
•
edited by larsbergstrom
This is a potential fix for #12842. I have done only the math to handle simple transforms because it's three AM, but I'd like @pcwalton to verify my approach, or suggest an alternative.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is