Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.12.0-nightly (1deb02ea6 2016-08-12) #12846

Merged
merged 3 commits into from Aug 13, 2016
Merged

Update Rust to 1.12.0-nightly (1deb02ea6 2016-08-12) #12846

merged 3 commits into from Aug 13, 2016
+24 −43

Conversation

@nox
Copy link
Member

nox commented Aug 13, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Aug 13, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/request.rs, components/net/fetch/cors_cache.rs
@highfive
Copy link

highfive commented Aug 13, 2016

warning Warning warning

  • These commits modify net, layout, and script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented Aug 13, 2016

Silly me... Blocked on Manishearth/rust-tenacious#19.
@jdm
Copy link
Member

jdm commented Aug 13, 2016

r+ when that's merged.
nox added 2 commits Aug 13, 2016
@nox
Remove rust_tenacious
f12fad7 
We don't use it anymore since #11872.
@nox
Update image to 0.10.2 to silence some warnings
9f5122f
@nox nox force-pushed the rustup branch from c0d8cad to b86a0b6 Aug 13, 2016
@nox
Copy link
Member Author

nox commented Aug 13, 2016

Actually rust-tenacious will never be correct anymore with MIR, and we don't actually use it anymore anyway since @eddyb removed our uses of return_address.
@nox
Copy link
Member Author

nox commented Aug 13, 2016

@jdm Feel free to r+, not doing it on your behalf because I removed rust-tenacious.
@nox
Copy link
Member Author

nox commented Aug 13, 2016

Blocked on compiletest-rs being updated.
@nox
Update Rust to 1.12.0-nightly (1deb02ea6 2016-08-12)
Loading status checks…
fc6faf7
@nox nox force-pushed the rustup branch from b86a0b6 to fc6faf7 Aug 13, 2016
@nox
Copy link
Member Author

nox commented Aug 13, 2016

compiletest just had to be updated to 0.2, should be ok now.
@emilio
Copy link
Member

emilio commented Aug 13, 2016

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 13, 2016

📌 Commit fc6faf7 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Aug 13, 2016

⌛ Testing commit fc6faf7 with merge 476df17...
bors-servo added a commit that referenced this pull request Aug 13, 2016
@bors-servo
Auto merge of #12846 - servo:rustup, r=emilio
Loading status checks…
476df17 
Update Rust to 1.12.0-nightly (1deb02ea6 2016-08-12)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12846)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 13, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 13, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@nox
Copy link
Member Author

nox commented Aug 13, 2016

@bors-servo retry #11561
@bors-servo
Copy link
Contributor

bors-servo commented Aug 13, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 13, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit fc6faf7 into master Aug 13, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the rustup branch Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @jdm @emilio @bors-servo
You can’t perform that action at this time.