Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GFX Warnings #12849

Merged
merged 1 commit into from Aug 14, 2016
Merged

Fix GFX Warnings #12849

merged 1 commit into from Aug 14, 2016

Conversation

@Coder206
Copy link
Contributor

Coder206 commented Aug 13, 2016 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12624 (github issue number if applicable).
  • There are tests for these changes OR

This change is Reviewable
@highfive
Copy link

highfive commented Aug 13, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.
@highfive
Copy link

highfive commented Aug 13, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Aug 14, 2016

Hmm... This doesn't seem to fix the warning for me (the actual private type in the interface is GlyphEntry).
@KiChjang
Copy link
Member

KiChjang commented Aug 14, 2016

Yes, GlyphEntry and DetailedGlyphStore should be made public.
@KiChjang KiChjang assigned KiChjang and unassigned pcwalton Aug 14, 2016
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 14, 2016

@KiChjang @emilio How do I get Servo to show me warnings when doing "./mach build -d"?
@jdm
Copy link
Member

jdm commented Aug 14, 2016

Modify a file in gfx to ensure that the crate gets rebuilt.
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 14, 2016

@jdm Thanks.
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

Can you please squash those commits, btw?
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 14, 2016

@wafflespeanut Absolutely!
@Coder206
Fix GFX Warnings
Loading status checks…
dd7daf2 
Corrections to GFX Warnings Fix
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

📌 Commit dd7daf2 has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned KiChjang Aug 14, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⌛ Testing commit dd7daf2 with merge 41296d2...
bors-servo added a commit that referenced this pull request Aug 14, 2016
@bors-servo
Auto merge of #12849 - Coder206:gfxWarnings, r=Wafflespeanut
Loading status checks…
41296d2 
Fix GFX Warnings

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12624 (github issue number if applicable).

- [ ] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12849)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

💔 Test failed - mac-rel-wpt
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

@bors-servo retry #11618
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit dd7daf2 into servo:master Aug 14, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Coder206 Coder206 deleted the Coder206:gfxWarnings branch Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Fix compiler warnings in gfx
8 participants
@Coder206 @highfive @emilio @KiChjang @jdm @wafflespeanut @bors-servo @pcwalton
You can’t perform that action at this time.