New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix step 31 of the Request constructor. #12851
Conversation
In addition to fixing step 31 of the Request constructor, this commit also: - remove get_current_url function, and use net_request::request's built-in current_url method - clean up unnecessary line breaks and comments
Heads up! This PR modifies the following files:
|
r? @nox |
@bors-servo r+ |
📌 Commit 2693027 has been approved by |
Fix step 31 of the Request constructor. <!-- Please describe your changes on the following line: --> This PR fixes the step 31 of the Request constructor to fill Request's Headers object and rethrow any exceptions. Additionally, it removes unnecessary line breaks, comments, and redundant function. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12845 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because this PR does not change the behavior of the Request constructor. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> In addition to fixing step 31 of the Request constructor, this commit also: - remove `get_current_url` function, and use `net_request::request`'s built-in `current_url` method - clean up unnecessary line breaks and comments <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12851) <!-- Reviewable:end -->
💔 Test failed - mac-rel-wpt |
|
@bors-servo retry #8769 |
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt... |
☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev |
This PR fixes the step 31 of the Request constructor to fill Request's Headers object and rethrow any exceptions. Additionally, it removes unnecessary line breaks, comments, and redundant function.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsIn addition to fixing step 31 of the Request constructor, this
commit also:
get_current_url
function, and usenet_request::request
'sbuilt-in
current_url
methodThis change is