Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix step 31 of the Request constructor. #12851
Merged
+3
−15
Conversation
In addition to fixing step 31 of the Request constructor, this commit also: - remove get_current_url function, and use net_request::request's built-in current_url method - clean up unnecessary line breaks and comments
highfive
commented
Aug 13, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Aug 13, 2016
|
|
|
r? @nox |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 13, 2016
Fix step 31 of the Request constructor. <!-- Please describe your changes on the following line: --> This PR fixes the step 31 of the Request constructor to fill Request's Headers object and rethrow any exceptions. Additionally, it removes unnecessary line breaks, comments, and redundant function. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12845 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because this PR does not change the behavior of the Request constructor. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> In addition to fixing step 31 of the Request constructor, this commit also: - remove `get_current_url` function, and use `net_request::request`'s built-in `current_url` method - clean up unnecessary line breaks and comments <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12851) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 13, 2016
|
|
@bors-servo retry #8769 |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jeenalee commentedAug 13, 2016
•
edited by larsbergstrom
This PR fixes the step 31 of the Request constructor to fill Request's Headers object and rethrow any exceptions. Additionally, it removes unnecessary line breaks, comments, and redundant function.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsIn addition to fixing step 31 of the Request constructor, this
commit also:
get_current_urlfunction, and usenet_request::request'sbuilt-in
current_urlmethodThis change is