Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iter_arith warning when running ./mach build-cef #12860

Merged
merged 1 commit into from Aug 14, 2016
Merged

Fix iter_arith warning when running ./mach build-cef #12860

merged 1 commit into from Aug 14, 2016

Conversation

@Coder206
Copy link
Contributor

Coder206 commented Aug 14, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12855 (github issue number if applicable).
  • There are tests for these changes (./mach build-cef)

This change is Reviewable
@highfive
Copy link

highfive commented Aug 14, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.
@highfive
Copy link

highfive commented Aug 14, 2016

warning Warning warning

  • These commits modify gfx code, but no tests are modified. Please consider adding a test!
@Coder206
Fix iter_arith warning when running ./mach build-cef
Loading status checks…
ca1fdb7
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

@bors-servo r+

Thanks! :)
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

📌 Commit ca1fdb7 has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned metajack Aug 14, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⌛ Testing commit ca1fdb7 with merge 24858e0...
bors-servo added a commit that referenced this pull request Aug 14, 2016
@bors-servo
Auto merge of #12860 - Coder206:iterWarn, r=Wafflespeanut
Loading status checks…
24858e0 
Fix iter_arith warning when running ./mach build-cef

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12855 (github issue number if applicable).

- [x] There are tests for these changes (./mach build-cef)

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12860)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 14, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@notriddle
Copy link
Contributor

notriddle commented Aug 14, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⌛ Testing commit ca1fdb7 with merge b5bd872...
bors-servo added a commit that referenced this pull request Aug 14, 2016
@bors-servo
Auto merge of #12860 - Coder206:iterWarn, r=Wafflespeanut
Loading status checks…
b5bd872 
Fix iter_arith warning when running ./mach build-cef

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12855 (github issue number if applicable).

- [x] There are tests for these changes (./mach build-cef)

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12860)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 14, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

@bors-servo retry #11561
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 14, 2016 

  ▶ Unexpected subtest result in /html/browsers/browsing-the-web/history-traversal/browsing_context_name.html:
  └ PASS [expected FAIL] Retaining window.name on history traversal
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

@bors-servo retry #12568
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⌛ Testing commit ca1fdb7 with merge 27472ff...
bors-servo added a commit that referenced this pull request Aug 14, 2016
@bors-servo
Auto merge of #12860 - Coder206:iterWarn, r=Wafflespeanut
Loading status checks…
27472ff 
Fix iter_arith warning when running ./mach build-cef

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12855 (github issue number if applicable).

- [x] There are tests for these changes (./mach build-cef)

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12860)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Aug 14, 2016 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/iframe/hide_layers2.html
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 14, 2016

@bors-servo retry #8769
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit ca1fdb7 into servo:master Aug 14, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Coder206 Coder206 deleted the Coder206:iterWarn branch Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Fix iter_arith warning when running ./mach build-cef
6 participants
@Coder206 @highfive @wafflespeanut @bors-servo @notriddle @metajack
You can’t perform that action at this time.