Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OS Links in Markdown #12880

Merged
merged 1 commit into from Aug 17, 2016
Merged

Added OS Links in Markdown #12880

merged 1 commit into from Aug 17, 2016

Conversation

@Coder206
Copy link
Contributor

Coder206 commented Aug 15, 2016 •
edited

It is really an improvement to make room for a commit that links contributors to https://janitor.technology

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

This change is Reviewable
@Coder206 Coder206 mentioned this pull request Aug 15, 2016
Closed
3 of 3 tasks complete
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 15, 2016

There is also added links for each OS so contributors can simply click their OS instead of scrolling through "endless" documentation.
@nox
Copy link
Member

nox commented Aug 16, 2016

@bors-servo r+ rollup
@bors-servo
Copy link
Contributor

bors-servo commented Aug 16, 2016

📌 Commit 6c56c45 has been approved by nox
@highfive highfive assigned nox and unassigned asajeffrey Aug 16, 2016
README.md Outdated
* [Microsoft Windows](#windows)
* [Android](#android)

<a name="osxHome"></a>

This comment has been minimized.

Sign in to view
Copy link
@Ms2ger

Ms2ger Aug 16, 2016

Contributor

Rather than using a elements, I'd use headers; github will generate ids automatically.

Also, I'd collapse the three OSX sections into one.
@nox
Copy link
Member

nox commented Aug 16, 2016

@bors-servo r-

What @Ms2ger said.
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 16, 2016

@nox @Ms2ger I made changes to the files based on documentation but I was unsuccessful in testing it in my markdown preview. Can you review the changes and see if they work on your end?
README.md Outdated

```sh
sudo emerge net-misc/curl media-libs/freeglut \
media-libs/freetype media-libs/mesa dev-util/gperf \
dev-python/virtualenv dev-python/pip dev-libs/openssl \
x11-libs/libXmu media-libs/glu x11-base/xorg-server
```

On Windows:
##### On Windows

This comment has been minimized.

Sign in to view
Copy link
@nox

nox Aug 16, 2016

Member

This one should be ####.
README.md Outdated
* [Arch Linux](#on-arch-linux)
* [Gentoo Linux](#on-gentoo-linux)
* [Microsoft Windows](#on-windows)
* [Android](#cross---compilation-for-android)

This comment has been minimized.

Sign in to view
Copy link
@nox

nox Aug 16, 2016

Member

cross-compilation-for-android
@nox
Copy link
Member

nox commented Aug 16, 2016 •
edited

Fix these two last things and it's ok.
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 16, 2016

@nox Awesome thanks, I wasn't sure for the Android one - it was a guess.
@KiChjang
Copy link
Member

KiChjang commented Aug 16, 2016

Squash!
@Coder206
Added OS Links in Markdown
Loading status checks…
0c9a718 
From a to header

Fixes for heading layout
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 17, 2016

@KiChjang Squash completed! :)
@emilio
Copy link
Member

emilio commented Aug 17, 2016

@bors-servo: r=nox,Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

📌 Commit 0c9a718 has been approved by nox,Ms2ger
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

⌛ Testing commit 0c9a718 with merge 17df3c2...
bors-servo added a commit that referenced this pull request Aug 17, 2016
@bors-servo
Auto merge of #12880 - Coder206:osReadMe, r=nox,Ms2ger
Loading status checks…
17df3c2 
Added OS Links in Markdown

<!-- Please describe your changes on the following line: -->

It is really an improvement to make room for a commit that links contributors to https://janitor.technology

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12880)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 17, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-004.htm
  └   → /css-transforms-1_dev/html/perspective-origin-004.htm 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22 == d4aa213e3e31e41d0d8e84aec79e94f860f27178

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-003.htm
  └   → /css-transforms-1_dev/html/perspective-origin-003.htm e79c0e9b3e8e596c5f445a33630e8d2333d30ec4
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing e79c0e9b3e8e596c5f445a33630e8d2333d30ec4 == d4aa213e3e31e41d0d8e84aec79e94f860f27178

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-007.htm
  └   → /css-transforms-1_dev/html/transform-abspos-007.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 17, 2016

@emilio Are the issues above related to #12886?
@emilio
Copy link
Member

emilio commented Aug 17, 2016

No, they aren't they're intermittents (#12891)

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 17, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 0c9a718 into servo:master Aug 17, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 17, 2016
Closed
3 of 3 tasks complete
@Coder206 Coder206 deleted the Coder206:osReadMe branch Aug 17, 2016
@Coder206 Coder206 restored the Coder206:osReadMe branch Aug 17, 2016
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 17, 2016

The links are broken. Nothing happens when I click on the them. Perhaps the code should be using the a element like before.
@emilio
Copy link
Member

emilio commented Aug 17, 2016

Huh... They work fine for me. Have you double-checked?
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 17, 2016

@emilio They don't work on my phone.
@Coder206
Copy link
Contributor Author

Coder206 commented Aug 17, 2016

When I try clucking on them, nothing happens on my phone except for the link changing to the appropriate header.
@Coder206 Coder206 mentioned this pull request Aug 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@Coder206 @nox @bors-servo @KiChjang @emilio @highfive @Ms2ger @asajeffrey
You can’t perform that action at this time.