Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger image.onerror #12921

Merged
merged 1 commit into from Aug 23, 2016
Merged

Trigger image.onerror #12921

merged 1 commit into from Aug 23, 2016

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Aug 18, 2016 •
edited

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #12885 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Aug 18, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/htmlimageelement.rs
@highfive
Copy link

highfive commented Aug 18, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@paulrouget paulrouget mentioned this pull request Aug 18, 2016
Closed
@nox
Copy link
Member

nox commented Aug 18, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

⌛ Trying commit 58465a6 with merge e419cfa...
bors-servo added a commit that referenced this pull request Aug 18, 2016
@bors-servo
Auto merge of #12921 - paulrouget:imgOnError, r=<try>
Loading status checks…
e419cfa 
Trigger image.onerror

WIP - no test yet

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12885 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 18, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-002.htm
  └   → /css-transforms-1_dev/html/perspective-origin-002.htm 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22 == d4aa213e3e31e41d0d8e84aec79e94f860f27178
@paulrouget paulrouget force-pushed the paulrouget:imgOnError branch from 58465a6 to 4429c42 Aug 18, 2016
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 18, 2016

Test added.
@nox
Copy link
Member

nox commented Aug 18, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

📌 Commit 4429c42 has been approved by nox
@highfive highfive assigned nox and unassigned wafflespeanut Aug 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

⌛ Testing commit 4429c42 with merge 508eac1...
bors-servo added a commit that referenced this pull request Aug 18, 2016
@bors-servo
Auto merge of #12921 - paulrouget:imgOnError, r=nox
Loading status checks…
508eac1 
Trigger image.onerror

WIP - no test yet

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12885 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12921)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 18, 2016

@bors-servo r-

Put the test in wpt.
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 18, 2016

Put the test in wpt.

Do I just need to move this test under tests/wpt/web-platform-tests/? If so, where do you recommend we to put it?
@nox
Copy link
Member

nox commented Aug 18, 2016

What about in tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/?
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 18, 2016

What about in tests/wpt/web-platform-tests/html/semantics/embedded-content/the-img-element/?

I see multiple img.onerror tests in there. I'll see why they don't seem to pass.
@paulrouget paulrouget force-pushed the paulrouget:imgOnError branch from cdb488c to 56c1901 Aug 22, 2016
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 22, 2016

I guess that should do it.
@nox
Copy link
Member

nox commented Aug 22, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

📌 Commit 56c1901 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

⌛ Testing commit 56c1901 with merge 514e276...
bors-servo added a commit that referenced this pull request Aug 22, 2016
@bors-servo
Auto merge of #12921 - paulrouget:imgOnError, r=nox
Loading status checks…
514e276 
Trigger image.onerror

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12885 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

💔 Test failed - mac-rel-wpt
@highfive
Copy link

highfive commented Aug 22, 2016 

  ▶ TIMEOUT [expected OK] /webgl/conformance-1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-svg-image.html
  │ 
  └ DESCRIPTION: Verify texImage2D and texSubImage2D code paths taking SVG image elements (RGBA/UNSIGNED_BYTE)
@jdm
Copy link
Member

jdm commented Aug 22, 2016

That test loads an SVG image and only uses onload; it now times out with these changes since we can't deal with SVG images. The test result will need to be updated.
@nox
Copy link
Member

nox commented Aug 22, 2016 •
edited

@bors-servo #11618 #12592

Wrong ticket, wrong command, what the hell did I do...
@paulrouget
Trigger image.onerror
Loading status checks…
a48cf1d
@paulrouget paulrouget force-pushed the paulrouget:imgOnError branch from 56c1901 to a48cf1d Aug 23, 2016
@paulrouget
Copy link
Contributor Author

paulrouget commented Aug 23, 2016

Green.
@wafflespeanut
Copy link
Member

wafflespeanut commented Aug 23, 2016

@bors-servo r=nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2016

📌 Commit a48cf1d has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2016

⌛ Testing commit a48cf1d with merge fe09cb5...
bors-servo added a commit that referenced this pull request Aug 23, 2016
@bors-servo
Auto merge of #12921 - paulrouget:imgOnError, r=nox
Loading status checks…
fe09cb5 
Trigger image.onerror

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #12885 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12921)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 23, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit a48cf1d into servo:master Aug 23, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

img onload is dispatched instead of onerror on failed requests
7 participants
@paulrouget @highfive @nox @bors-servo @Ms2ger @jdm @wafflespeanut
You can’t perform that action at this time.