Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selectors to 0.10, with ToCss serialization. #12924

Merged
merged 3 commits into from Aug 19, 2016
Merged

Update selectors to 0.10, with ToCss serialization. #12924

merged 3 commits into from Aug 19, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Aug 18, 2016 •
edited by larsbergstrom

r? @emilio

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@SimonSapin
Update selectors to 0.10, with ToCss serialization.
Loading status checks…
d690bd2
@highfive
Copy link

highfive commented Aug 18, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/servo_selector_impl.rs, components/style/restyle_hints.rs, components/style/gecko_selector_impl.rs
  • @KiChjang: components/script/dom/element.rs, components/script/Cargo.toml, components/script_layout_interface/Cargo.toml, components/script/layout_wrapper.rs
SimonSapin added 2 commits Aug 18, 2016
@SimonSapin
Add missing try!() around write!()
84fed1a 
Fixes "unused result" warning.
@SimonSapin
Atomize namespace prefixes.
Loading status checks…
6173e1d
@nox
Copy link
Member

nox commented Aug 18, 2016

Reviewed 20 of 20 files at r1, 1 of 1 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@nox
Copy link
Member

nox commented Aug 18, 2016

@bors-servo r+

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

📌 Commit 6173e1d has been approved by nox
@highfive highfive assigned nox and unassigned emilio Aug 18, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

⌛ Testing commit 6173e1d with merge 6235ac4...
bors-servo added a commit that referenced this pull request Aug 18, 2016
@bors-servo
Auto merge of #12924 - servo:selectors-ser, r=nox
Loading status checks…
6235ac4 
Update selectors to 0.10, with ToCss serialization.

<!-- Please describe your changes on the following line: -->
r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12924)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 18, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-005.htm
  └   → /css-transforms-1_dev/html/perspective-origin-005.htm 719003ff0f2c5efe0b678a757a454870ca362e2c
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing 719003ff0f2c5efe0b678a757a454870ca362e2c == d4aa213e3e31e41d0d8e84aec79e94f860f27178

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-003.htm
  └   → /css-transforms-1_dev/html/perspective-origin-003.htm e79c0e9b3e8e596c5f445a33630e8d2333d30ec4
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing e79c0e9b3e8e596c5f445a33630e8d2333d30ec4 == d4aa213e3e31e41d0d8e84aec79e94f860f27178

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-table-007.htm
  └   → /css-transforms-1_dev/html/transform-table-007.htm a5c014b20ef1363bea6f24eda28c7efb7c45698a
/css-transforms-1_dev/html/reference/transform-blank-ref.htm fa6407b1acbbfea27e27061e7d1bdeca98e4a728
Testing a5c014b20ef1363bea6f24eda28c7efb7c45698a == fa6407b1acbbfea27e27061e7d1bdeca98e4a728
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 18, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⌛ Testing commit 6173e1d with merge 7d66055...
bors-servo added a commit that referenced this pull request Aug 19, 2016
@bors-servo
Auto merge of #12924 - servo:selectors-ser, r=nox
7d66055 
Update selectors to 0.10, with ToCss serialization.

<!-- Please describe your changes on the following line: -->
r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12924)
<!-- Reviewable:end -->
@Manishearth Manishearth reopened this Aug 19, 2016
@Manishearth
Copy link
Member

Manishearth commented Aug 19, 2016

@bors r=nox retry clean
@Manishearth Manishearth reopened this Aug 19, 2016
@Manishearth
Copy link
Member

Manishearth commented Aug 19, 2016

@bors r=nox retry clean
@Manishearth
Copy link
Member

Manishearth commented Aug 19, 2016

@bors-servo clean retry r-
@Manishearth
Copy link
Member

Manishearth commented Aug 19, 2016

@bors-servo clean r=nox
bors-servo added a commit that referenced this pull request Aug 19, 2016
@bors-servo
Auto merge of #12924 - servo:selectors-ser, r=nox
Loading status checks…
b62cb93 
Update selectors to 0.10, with ToCss serialization.

<!-- Please describe your changes on the following line: -->
r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12924)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 19, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-006.htm
  └   → /css-transforms-1_dev/html/perspective-origin-006.htm d2f9f49eb190646b004d0ea13de938dfa265561d
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing d2f9f49eb190646b004d0ea13de938dfa265561d == d4aa213e3e31e41d0d8e84aec79e94f860f27178
@nox
Copy link
Member

nox commented Aug 19, 2016

@bors-servo retry #12891
@nox
Copy link
Member

nox commented Aug 19, 2016

@bors-servo force
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 19, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/transform-abspos-002.htm
  └   → /css-transforms-1_dev/html/transform-abspos-002.htm 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8
/css-transforms-1_dev/html/reference/transform-abspos-ref.htm 78d197606924062e8dd2a773c977afcecf8940f8
Testing 71f0313eedfbfcce0b0fcc5ae55f34b1daa3b8d8 == 78d197606924062e8dd2a773c977afcecf8940f8
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 19, 2016

@bors-servo retry
@nox
Copy link
Member

nox commented Aug 19, 2016

@bors-servo force
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⛄ The build was interrupted to prioritize another pull request.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, windows-dev are reusable. Rebuilding only linux-rel, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

💔 Test failed - linux-rel
@highfive
Copy link

highfive commented Aug 19, 2016 

  ▶ FAIL [expected PASS] /css-transforms-1_dev/html/perspective-origin-004.htm
  └   → /css-transforms-1_dev/html/perspective-origin-004.htm 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22
/css-transforms-1_dev/html/reference/ref-filled-green-100px-square.htm d4aa213e3e31e41d0d8e84aec79e94f860f27178
Testing 68d5e8d6d5edcd2bef5ecaaf62cbbbac863dee22 == d4aa213e3e31e41d0d8e84aec79e94f860f27178
@SimonSapin
Copy link
Member Author

SimonSapin commented Aug 19, 2016

@bors-servo retry

Hopefully will have an easier time landing after #12942.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⌛ Testing commit 6173e1d with merge 07b2173...
bors-servo added a commit that referenced this pull request Aug 19, 2016
@bors-servo
Auto merge of #12924 - servo:selectors-ser, r=nox
Loading status checks…
07b2173 
Update selectors to 0.10, with ToCss serialization.

<!-- Please describe your changes on the following line: -->
r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12924)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 6173e1d into master Aug 19, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the selectors-ser branch Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@SimonSapin @highfive @nox @bors-servo @Manishearth @emilio
You can’t perform that action at this time.