Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending pipelines to Frame instantly #12928

Closed
wants to merge 7 commits into from
Closed

Add pending pipelines to Frame instantly #12928

wants to merge 7 commits into from
+173 −185

Conversation

@cbrewster
Copy link
Member

cbrewster commented Aug 18, 2016 •
edited by larsbergstrom

r? @asajeffrey
Experimenting right now.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Aug 18, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
  • @KiChjang: components/script/script_thread.rs
@highfive
Copy link

highfive commented Aug 18, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@cbrewster
Copy link
Member Author

cbrewster commented Aug 18, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

⌛ Trying commit 63e4f31 with merge cdce991...
bors-servo added a commit that referenced this pull request Aug 18, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
cdce991 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2016

💔 Test failed - mac-rel-wpt
@cbrewster
Copy link
Member Author

cbrewster commented Aug 19, 2016

@bors-servo try
Trying to figure out what message is being sent.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 19, 2016

⌛ Trying commit 269f501 with merge 1ec3181...
bors-servo added a commit that referenced this pull request Aug 19, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
1ec3181 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@cbrewster cbrewster force-pushed the cbrewster:pending_pipelines branch from 269f501 to 2156005 Aug 20, 2016
@cbrewster
Copy link
Member Author

cbrewster commented Aug 20, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 20, 2016

⌛ Trying commit 2156005 with merge 8248b96...
bors-servo added a commit that referenced this pull request Aug 20, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
8248b96 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 20, 2016

💔 Test failed - linux-rel
@cbrewster cbrewster force-pushed the cbrewster:pending_pipelines branch from 2156005 to 2d87669 Aug 21, 2016
@cbrewster
Copy link
Member Author

cbrewster commented Aug 21, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

⌛ Trying commit 2d87669 with merge 31332b5...
bors-servo added a commit that referenced this pull request Aug 21, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
31332b5 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@cbrewster cbrewster force-pushed the cbrewster:pending_pipelines branch from 2d87669 to a2453c6 Aug 21, 2016
@cbrewster
Copy link
Member Author

cbrewster commented Aug 21, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

⌛ Trying commit a2453c6 with merge 176e68a...
bors-servo added a commit that referenced this pull request Aug 21, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
176e68a 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 21, 2016

💔 Test failed - mac-rel-wpt
cbrewster added 4 commits Aug 11, 2016
@cbrewster
Add pending pipeline to current instead of next
a8c4801
@cbrewster
store pending state
4cbc56d 
Don't request title from pending pipeline
@cbrewster
Add testing assert
ba1a3f1
@cbrewster
Check if pipeline is pending before attempting to activate it
Loading status checks…
0a88691
@cbrewster cbrewster force-pushed the cbrewster:pending_pipelines branch from 3c73d6d to 0a88691 Sep 3, 2016
@highfive highfive removed the S-tests-failed label Sep 3, 2016
@cbrewster
Copy link
Member Author

cbrewster commented Sep 3, 2016

@bors-servo try
bors-servo added a commit that referenced this pull request Sep 3, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
4903c2c 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2016

⌛ Trying commit 0a88691 with merge 4903c2c...
@bors-servo
Copy link
Contributor

bors-servo commented Sep 3, 2016

💔 Test failed - linux-rel
@cbrewster
add assertion before sending frame tree to compositor
Loading status checks…
ee259cc
@highfive highfive removed the S-tests-failed label Sep 5, 2016
@cbrewster
Copy link
Member Author

cbrewster commented Sep 5, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2016

⌛ Trying commit ee259cc with merge 5e4fb41...
bors-servo added a commit that referenced this pull request Sep 5, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
5e4fb41 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2016

💔 Test failed - mac-rel-css
@cbrewster
remove pending pipelines from current frame tree
Loading status checks…
5d15e5f
@highfive highfive removed the S-tests-failed label Sep 5, 2016
@cbrewster
Copy link
Member Author

cbrewster commented Sep 5, 2016

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2016

⌛ Trying commit 5d15e5f with merge c53e510...
bors-servo added a commit that referenced this pull request Sep 5, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
c53e510 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 5, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@cbrewster
Copy link
Member Author

cbrewster commented Sep 7, 2016

@bors-servo retry

  • one more time before cleanup
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

⌛ Trying commit 5d15e5f with merge a731360...
bors-servo added a commit that referenced this pull request Sep 7, 2016
@bors-servo
Auto merge of #12928 - ConnorGBrewster:pending_pipelines, r=<try>
Loading status checks…
a731360 
Add pending pipelines to Frame instantly

<!-- Please describe your changes on the following line: -->
r? @asajeffrey
Experimenting right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12928)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 7, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@cbrewster
Copy link
Member Author

cbrewster commented Sep 12, 2016

Closing, as it seems this may not be the best approach.
@cbrewster cbrewster closed this Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@cbrewster @highfive @bors-servo @nox @asajeffrey
You can’t perform that action at this time.