Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updisable browsing context name test #12929
Merged
+1
−3
Conversation
| [Retaining window.name on history traversal] | ||
| expected: FAIL | ||
|
|
||
| disabled: see https://github.com/whatwg/html/issues/490 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
metajack
Aug 18, 2016
Contributor
The test looks for events for an iframe onload for each step. The initial frame has no src attribute, which means it will load about:blank. Based on whatwg/html#490, it looks like the behavior is unknown when the src changes before the onload event fires. That would make this test racy depending on the browser I'm guessing.
|
@bors-servo r+ |
|
|
|
@bors-servo p=10 |
bors-servo
added a commit
that referenced
this pull request
Aug 19, 2016
disable browsing context name test <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12929) <!-- Reviewable:end -->
|
|
highfive
commented
Aug 19, 2016
|
|
@bors-servo retry |
|
|
|
|
highfive
commented
Aug 19, 2016
|
|
@bors-servo retry |
|
|
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Aug 19, 2016
disable browsing context name test <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12929) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cbrewster commentedAug 18, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is