Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Etc ci performance run locally #12946

Merged
merged 17 commits into from Sep 6, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Added --local option to test_all.sh.

  • Loading branch information
asajeffrey committed Aug 19, 2016
commit f81e32e3341c3c867a2392bd37a8cb51adaa618d
@@ -8,19 +8,29 @@ set -o errexit
set -o nounset
set -o pipefail

case "${1}" in
while (( "$#" ))
do
case "$1" in
--servo)
engine="--engine servo"
;;
--gecko)
engine="--engine gecko"
;;
--local)

This comment has been minimized.

@shinglyu

shinglyu Aug 23, 2016

Member

Since most people trying this out will be running it locally, would you mind inverting the flag? Let's NOT submit to perfherder by default, and trigger the submit_to_perfherder.py only if we specify --upload-result.

This comment has been minimized.

@asajeffrey

asajeffrey Sep 5, 2016

Author Member

Done. There is now a --submit flag which runs submit_to_perfherder.py.

local=1
;;
*)
# This branch should never be reached with set -o nounset
echo "You didn't specify the engine to run."
echo "Unknown option $1."
exit
;;
esac
shift
done

if [ -z "${engine:-}" ];
then echo "You didn't specify the engine to run: either --servo or --gecko."; exit;
fi

echo "Starting the local server"
python3 -m http.server > /dev/null 2>&1 &
@@ -33,15 +43,18 @@ MANIFEST="page_load_test/tp5n/20160509.manifest" # A manifest that excludes
PERF_FILE="output/perf-$(date --iso-8601=seconds).json"

echo "Running tests"
python3 runner.py "${engine}" --runs 3 "${MANIFEST}" "${PERF_FILE}"

echo "Submitting to Perfherder"
# Perfherder SSL check will fail if time is not accurate,
# sync time before you submit
# TODO: we are using Servo's revision hash for Gecko's result to make both
# results appear on the same date. Use the correct result when Perfherder
# allows us to change the date.
python3 submit_to_perfherder.py "${engine}" "${PERF_FILE}" servo/revision.json

# Kill the http server
python3 runner.py ${engine} --runs 3 "${MANIFEST}" "${PERF_FILE}"

if [ -z "${local:-}" ];
then
echo "Submitting to Perfherder"
# Perfherder SSL check will fail if time is not accurate,
# sync time before you submit
# TODO: we are using Servo's revision hash for Gecko's result to make both
# results appear on the same date. Use the correct result when Perfherder
# allows us to change the date.
python3 submit_to_perfherder.py "${output:-}" "${engine}" "${PERF_FILE}" servo/revision.json
fi

echo "Stopping the local server"
trap 'kill $(jobs -pr)' SIGINT SIGTERM EXIT
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.