Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWindows MSVC: Define vcvars in mach.bat #12956
Merged
Conversation
mach.bat
Outdated
| IF EXIST "%ProgramFiles(x86)%" ( | ||
| call "%VS_VCVARS%" x64 | ||
| ) ELSE ( | ||
| call "%VS_VCVARS%" x86 |
This comment has been minimized.
This comment has been minimized.
|
This is great, but I think we need to bail if we aren't on a 64bit system. |
|
done. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 22, 2016
Windows MSVC: Define vcvars in mach.bat Define vcvars for msvc build, if they have not yet been. If vcvars not exist, show message that visual studio 2015 is not installed and where to download it. Fixes #12948 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12956) <!-- Reviewable:end -->
|
|
naughtywoods23 left a comment
|
works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
UK992 commentedAug 20, 2016
•
edited by KiChjang
Define vcvars for msvc build, if they have not yet been. If vcvars not exist, show message that visual studio 2015 is not installed and where to download it.
Fixes #12948
This change is