Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move thread_state to style. #12970

Merged
merged 1 commit into from Aug 22, 2016
Merged

Move thread_state to style. #12970

merged 1 commit into from Aug 22, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Aug 22, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Move thread_state to style.
Loading status checks…
307d1ce
@highfive
Copy link

highfive commented Aug 22, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/lib.rs, components/style/workqueue.rs, components/style/thread_state.rs
  • @KiChjang: components/script/dom/bindings/cell.rs, components/script/dom/node.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/script_thread.rs, components/script/dom/bindings/js.rs, components/script/script_runtime.rs, components/script/dom/serviceworkerglobalscope.rs
@highfive
Copy link

highfive commented Aug 22, 2016

warning Warning warning

  • These commits modify style, gfx, and script code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member

nox commented Aug 22, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

📌 Commit 307d1ce has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

⌛ Testing commit 307d1ce with merge 1911606...
bors-servo added a commit that referenced this pull request Aug 22, 2016
@bors-servo
Auto merge of #12970 - servo:thread-state, r=nox
Loading status checks…
1911606 
Move thread_state to style.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12970)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Aug 22, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev
@bors-servo bors-servo merged commit 307d1ce into master Aug 22, 2016
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Aug 22, 2016
Merged
4 of 4 tasks complete
@SimonSapin SimonSapin deleted the thread-state branch Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Ms2ger @highfive @nox @bors-servo
You can’t perform that action at this time.