Add headless rendering mode, and run WPT tests with Webrender enabled. #12989

glennw · 2016-08-23T06:50:09Z

This change is

highfive · 2016-08-23T06:50:13Z

Heads up! This PR modifies the following files:

@wafflespeanut: python/servo/post_build_commands.py, python/servo/command_base.py, python/servo/testing_commands.py
@jgraham: tests/wpt/harness/wptrunner/browsers/servodriver.py, tests/wpt/harness/wptrunner/executors/executorservo.py, tests/wpt/harness/wptrunner/browsers/servo.py, tests/wpt/harness/requirements_servo.txt, tests/wpt/harness/wptrunner/wptcommandline.py

highfive · 2016-08-23T06:50:14Z

Warning

These commits modify unsafe code. Please review it carefully!

glennw · 2016-08-23T06:50:30Z

DO NOT MERGE!

(This PR is for testing on the build machines)

glennw · 2016-08-23T06:50:43Z

@bors-servo try

bors-servo · 2016-08-23T06:50:46Z

⌛ Trying commit 367f635 with merge 08eb420...


        Auto merge of #12989 - glennw:headless, r=<try>

Add headless rendering mode, and run WPT tests with Webrender enabled.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12989)

bors-servo · 2016-08-23T06:52:07Z

💔 Test failed - linux-dev

glennw · 2016-08-24T01:10:00Z

@aneeshusa @metajack @larsbergstrom This is failing to build on the linux builders (says it can't find libedit to link to in the travis logs).

Any idea why this would happen? I thought libedit would be installed on all ubuntu base machines. I created a local 14.04.5 ubuntu VM, and managed to build successfully without having to install libedit.

I could try to just add libedit to the dependencies list in saltfs, but it seems like it might be something else, since I didn't have that problem on a local VM.

Any ideas?

glennw · 2016-08-24T01:10:42Z

cc @edunham too for any ideas on the question above.

larsbergstrom · 2016-08-24T01:23:05Z

Hrm, yeah, the package for libedit-dev definitely got added to the Travis images:
travis-ci/travis-ci#3581

I do notice that the files are in an architecture-specific path:
https://packages.debian.org/jessie/amd64/libedit2/filelist
https://packages.debian.org/jessie/amd64/libedit-dev/filelist

i.e.,

/usr/lib/x86_64-linux-gnu/libedit.a
/usr/lib/x86_64-linux-gnu/libedit.so

Can you ensure that Travis is passing the right thing? I don't see the full link args. I wonder if we should change the --verbose argument to mach to pass -vv to cargo so we always get more link info...

glennw · 2016-08-24T02:14:44Z

@bors-servo try

bors-servo · 2016-08-24T02:14:46Z

⌛ Trying commit 7c1ab2b with merge f228531...


        Auto merge of #12989 - glennw:headless, r=<try>

Add headless rendering mode, and run WPT tests with Webrender enabled.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12989)

bors-servo · 2016-08-24T02:16:17Z

💔 Test failed - arm64

glennw · 2016-08-24T02:20:52Z

@bors-servo try

bors-servo · 2016-08-24T02:20:54Z

⌛ Trying commit f854e1e with merge 41cee5a...


        Auto merge of #12989 - glennw:headless, r=<try>

Add headless rendering mode, and run WPT tests with Webrender enabled.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12989)

bors-servo · 2016-08-24T02:22:08Z

💔 Test failed - linux-rel

bors-servo · 2016-09-22T09:09:12Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

glennw · 2016-09-22T09:10:32Z

👍 💥 🤘

glennw · 2016-09-22T19:19:41Z

@bors-servo try

bors-servo · 2016-09-22T19:19:43Z

⌛ Trying commit 7069a7f with merge 701ec1b...


        Auto merge of #12989 - glennw:headless, r=<try>

Add headless rendering mode, and run WPT tests with Webrender enabled.  This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12989)

bors-servo · 2016-09-22T20:31:49Z

💔 Test failed - linux-rel

highfive · 2016-09-22T20:31:51Z

  ▶ FAIL [expected PASS] /css-backgrounds-3_dev/html4/background-size-025.htm
  └   → /css-backgrounds-3_dev/html4/background-size-025.htm 2ea3e9ca7e4e2240bd95bb6deb98ca225529708e
/css-backgrounds-3_dev/html4/reference/background-size-025-ref.htm 7fc2ddd8cc52163a417c8aba45a68a099418a2e1
Testing 2ea3e9ca7e4e2240bd95bb6deb98ca225529708e == 7fc2ddd8cc52163a417c8aba45a68a099418a2e1


        Add updated test expectations.


        REMOVE BEFORE MERGE - Use webrender headless branch for CI testing.


        Allow selecting webrender when in headless mode.


        Allow script initiated scrolls, now that they are supported in webren…

…der.


        Add dependency for compiling OSMesa.


        Update webgl paint code to match webrender behaviour change. This

means that creation of the fallback reader painter in webrender mode is handled by webrender itself. This allows webrender to create the correct kind of context (osmesa or hardware) instead of the webgl paint thread having to deal with this.


        Add support for headless mode to create an OSMesa context.

This enables rendering to be consistent on build machines in headless mode, regardless of the GPU hardware / drivers present.


        Pass correct render context kind to webrender during startup.


        Run WPT servo tests with webrender headless mode enabled.


        Find the locally built OSMesa libs on mac/linux, and add them

to the dynamic library search path.


        cargo.lock file updates.


        Add mako requirement for osmesa build.

glennw · 2016-09-22T23:19:34Z

Closing in order to open a fresh PR for review.

jdm · 2016-09-22T23:28:17Z

These changes will need to be upstreamed as well.

jdm · 2016-09-22T23:28:58Z

Have we figured out why this crashes?

glennw · 2016-09-23T01:52:10Z

This test produces a non-invertible matrix that WR panics on - servo/webrender#418.

jdm · 2016-09-22T23:29:20Z

Reason?

glennw · 2016-09-23T01:52:18Z

This test produces a non-invertible matrix that WR panics on - servo/webrender#418.

highfive assigned emilio Aug 23, 2016

highfive added the S-awaiting-review label Aug 23, 2016

highfive added the S-tests-failed label Aug 23, 2016

glennw force-pushed the glennw:headless branch from 367f635 to c08b89e Aug 23, 2016

highfive removed the S-tests-failed label Aug 23, 2016

glennw force-pushed the glennw:headless branch 3 times, most recently from 568cce7 to f46cb6f Aug 23, 2016

glennw force-pushed the glennw:headless branch from f46cb6f to 7c1ab2b Aug 24, 2016

highfive added the S-tests-failed label Aug 24, 2016

glennw force-pushed the glennw:headless branch from 7c1ab2b to f854e1e Aug 24, 2016

highfive removed the S-tests-failed label Aug 24, 2016

glennw force-pushed the glennw:headless branch from 3cee2f2 to 7069a7f Sep 22, 2016

highfive added the S-tests-failed label Sep 22, 2016

glennw force-pushed the glennw:headless branch from 7069a7f to 58171d2 Sep 22, 2016

highfive removed the S-tests-failed label Sep 22, 2016

glennw force-pushed the glennw:headless branch from 58171d2 to 8bfc153 Sep 22, 2016

gw3583 added 12 commits Sep 22, 2016

Add updated test expectations.

4c6aad5

REMOVE BEFORE MERGE - Use webrender headless branch for CI testing.

0cc251a

Allow selecting webrender when in headless mode.

ae24306

Allow script initiated scrolls, now that they are supported in webren…

9a9eeab

…der.

Add dependency for compiling OSMesa.

07fe44c

Add support for headless mode to create an OSMesa context.

2bb73ae

This enables rendering to be consistent on build machines in headless mode, regardless of the GPU hardware / drivers present.

Pass correct render context kind to webrender during startup.

3dfb0a5

Run WPT servo tests with webrender headless mode enabled.

5fa859f

Find the locally built OSMesa libs on mac/linux, and add them

5bd7d16

to the dynamic library search path.

cargo.lock file updates.

ca8b682

Add mako requirement for osmesa build.

Loading status checks…

5ad48af

glennw force-pushed the glennw:headless branch from 8bfc153 to 5ad48af Sep 22, 2016

glennw closed this Sep 22, 2016

servo / servo

Add headless rendering mode, and run WPT tests with Webrender enabled. #12989

Add headless rendering mode, and run WPT tests with Webrender enabled. #12989

glennw commented Aug 23, 2016 •

edited by larsbergstrom

highfive commented Aug 23, 2016

highfive commented Aug 23, 2016

glennw commented Aug 23, 2016

glennw commented Aug 23, 2016

bors-servo commented Aug 23, 2016

bors-servo commented Aug 23, 2016

glennw commented Aug 24, 2016

glennw commented Aug 24, 2016

larsbergstrom commented Aug 24, 2016

glennw commented Aug 24, 2016

bors-servo commented Aug 24, 2016

bors-servo commented Aug 24, 2016

glennw commented Aug 24, 2016

bors-servo commented Aug 24, 2016

bors-servo commented Aug 24, 2016

bors-servo commented Sep 22, 2016

glennw commented Sep 22, 2016

glennw commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

highfive commented Sep 22, 2016

glennw commented Sep 22, 2016

This comment has been minimized.

jdm commented on `5fa859f` Sep 22, 2016

This comment has been minimized.

jdm commented on `tests/wpt/metadata-css/css-transforms-1_dev/html/scale-zero-001.htm.ini` in `4c6aad5` Sep 22, 2016

This comment has been minimized.

glennw replied Sep 23, 2016

This comment has been minimized.

jdm commented on `tests/wpt/metadata-css/css-transforms-1_dev/html/transform3d-scale-004.htm.ini` in `4c6aad5` Sep 22, 2016

This comment has been minimized.

glennw replied Sep 23, 2016

servo / servo

Join GitHub today

Add headless rendering mode, and run WPT tests with Webrender enabled. #12989

Add headless rendering mode, and run WPT tests with Webrender enabled. #12989

Conversation

glennw commented Aug 23, 2016 • edited by larsbergstrom

highfive commented Aug 23, 2016

highfive commented Aug 23, 2016

glennw commented Aug 23, 2016

glennw commented Aug 23, 2016

bors-servo commented Aug 23, 2016

bors-servo commented Aug 23, 2016

glennw commented Aug 24, 2016

glennw commented Aug 24, 2016

larsbergstrom commented Aug 24, 2016

glennw commented Aug 24, 2016

bors-servo commented Aug 24, 2016

bors-servo commented Aug 24, 2016

glennw commented Aug 24, 2016

bors-servo commented Aug 24, 2016

bors-servo commented Aug 24, 2016

bors-servo commented Sep 22, 2016

glennw commented Sep 22, 2016

glennw commented Sep 22, 2016

bors-servo commented Sep 22, 2016

bors-servo commented Sep 22, 2016

highfive commented Sep 22, 2016

glennw commented Sep 22, 2016

This comment has been minimized.

jdm commented on 5fa859f Sep 22, 2016

This comment has been minimized.

jdm commented on tests/wpt/metadata-css/css-transforms-1_dev/html/scale-zero-001.htm.ini in 4c6aad5 Sep 22, 2016

This comment has been minimized.

glennw replied Sep 23, 2016

This comment has been minimized.

jdm commented on tests/wpt/metadata-css/css-transforms-1_dev/html/transform3d-scale-004.htm.ini in 4c6aad5 Sep 22, 2016

This comment has been minimized.

glennw replied Sep 23, 2016

glennw commented Aug 23, 2016 •

edited by larsbergstrom

jdm commented on `5fa859f` Sep 22, 2016

jdm commented on `tests/wpt/metadata-css/css-transforms-1_dev/html/scale-zero-001.htm.ini` in `4c6aad5` Sep 22, 2016

jdm commented on `tests/wpt/metadata-css/css-transforms-1_dev/html/transform3d-scale-004.htm.ini` in `4c6aad5` Sep 22, 2016